Got it. In that case...

- Reports look good.
- Hashes and signatures are good.
- Userguide now lists JDK 8 as a requirement.
- Builds with the following (from the source distribution):

mvn clean install site site:stage -Pcommons-rng-examples

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Users\matt\tools\apache-maven-3.6.3-bin\apache-maven-3.6.3\bin\..
Java version: 11.0.12, vendor: Eclipse Foundation, runtime: C:\Program
Files\Eclipse Foundation\jdk-11.0.12.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

mvn clean install

Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
2018-02-24T14:49:05-05:00)
Maven home: /home/matt/tools/maven/apache-maven-3.5.3
Java version: 1.8.0_292, vendor: Private Build
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-81-generic", arch: "amd64", family: "unix"

Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
2018-02-24T14:49:05-05:00)
Maven home: /home/matt/tools/maven/apache-maven-3.5.3
Java version: 11.0.2, vendor: Oracle Corporation
Java home: /home/matt/lang/java/jdk-11.0.2
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-81-generic", arch: "amd64", family: "unix"

[X] +1 Release these artifacts

Regards,
Matt Juntunen


On Mon, Sep 6, 2021 at 8:53 AM Alex Herbert <alex.d.herb...@gmail.com> wrote:
>
> Hi,
>
> On Mon, 6 Sept 2021 at 13:13, Matt Juntunen <matt.a.juntu...@gmail.com>
> wrote:
>
> > The windows build is fixed. Before I cast my vote, can someone remind
> > me what to do to verify the nexus artifacts?
> >
>
> Thanks for checking.
>
> The nexus items are convenience artifacts. IIUC the vote is specifically
> for the source release. All derived release artifacts are non-essential to
> the release vote.
>
> The link in the vote e-mail for the nexus artifacts was wrong (I did not
> change it from the auto generated link created by the commons release
> plugin). Here are the artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1571/org/apache/commons/
>
> A laborious way to verify them is to download them, manually install them
> or put them on the classpath and then run them in a test application. You
> can add this repository to a maven project POM and then maven should be
> able to download them (I've not tried that but may give it a go to check if
> it's possible). An ideal way to test them would be to run all the unit
> tests from the source download against the maven artifacts. I do not recall
> anyone performing these actions on a previous vote. A quick browse of the
> staged artifacts to check the expected jars are present should be enough.
> The release guide expects for each module:
>
> .pom
> .jar
> .javadoc.jar
> .sources.jar
> .tests.jar
> .test-sources.jar
>
> The parent POM should also be staged.
>
> I did notice that the parent module has a site.xml staged in nexus. This
> must be a default for any project with the pom packaging as it also happens
> for commons-parent (you can find this in maven central). I do not know why
> you would want to include the site.xml as a dependency so perhaps this is
> something to clean up in the commons release plugin.
>
> Alex

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to