Hi. Le mer. 2 févr. 2022 à 09:29, Avijit Basak <avijit.ba...@gmail.com> a écrit : > > Hi All > > Please see my comments below. > > [...] > > > And there was this old issue that the "<artifactId>" should contain > the name of the top-level package, i.e. "math4", not "math". > -- There was a review comment for PR#197 to remove 4 from artifactid. > "aherbert <https://github.com/aherbert> on Sep 25, 2021 > <https://github.com/apache/commons-math/pull/197#discussion_r716075956> > > Remove the 4 from math4. The version is specified separately from the > artifact ID."
Indeed, it seems that there are discrepant expectations or a misunderstanding about how to compose the "<artifactId>". In "Commons Math", it contains "math4" as (IIUC) a unique identifier of the top-level package (that is updated with every major version). Because of that latter convention, it is true that the "4" is redundant with the (major) version number. However, it could also be construed that the redundancy may be useful for stressing that artefacts with different major versions can be used together (without "JAR hell"). That view of having the "packageId" as part of the artifact's name is used in some other components (e.g. "[Lang]"[1]) but not all (e.g. "[IO]"[2])... > > I've updated the feature branch with those changes. Please rebase. > > I've not yet looked at the code, but a question arose from looking at > the dependencies: What is "jfreechart" used for in the "examples"? > -- jfreechart is used to do a graphical plot of the optimization process. > > I've just updated the "k-means" example, removing the GUI along > the way. In general, I think that the example applications should > follow the KISS principle (which here translates to: Only write to the > console or to files). Since we don't intend to write full-fledged > applications, building/testing should be as smooth as possible: GUIs > entail unnecessary hassle for someone working from a remote > (text) terminal. > -- I shall remove that and the corresponding part of the code. Thanks. Please note that I don't suggest that you remove the tracking of the optimization process (it is useful to have a trace in order to check that evolution proceeds as expected), instead of displaying a GUI, you can save snapshots (either in text form or, if the check is more easily done graphically, by using the "[Imaging]" component[3]). Regards, Gilles > [...] > [1] https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob;f=pom.xml;h=4f12fdf537fd56a69d1b94567e22de99761ec775;hb=HEAD#l28 [2] https://gitbox.apache.org/repos/asf?p=commons-io.git;a=blob;f=pom.xml;h=8f61ca0177a056a80dda656dbb70a9774adac548;hb=HEAD#l26 [3] See e.g. the "kmeans/image" module. > > Thanks & Regards > --Avijit Basak > > On Tue, 1 Feb 2022 at 05:24, Gilles Sadowski <gillese...@gmail.com> wrote: > > > Hello. > > > > Le lun. 31 janv. 2022 à 06:27, Avijit Basak <avijit.ba...@gmail.com> a > > écrit : > > > > > > Hi All > > > > > > Please find my comments below. > > > > > > >There is no attachment (I think that the ML manager strips those). > > > >Please copy/paste the relevant part of the console log (or provide > > > >a link to it). > > > --The build was done locally with a fresh clone of the feature branch. > > > > Strange that the "pom.xml" in PR #204 still refers to version 1.0 of > > Commons Numbers, instead of version 1.1-SNAPSHOT. > > This creates many "NoClassDefFound" errors that were fixed with > > commit 7e2213f2e5a536ad49d549d21f9eed9e71db5638 in branch > > "feature__MATH-1563__genetic_algorithm" branch 6 days ago. > > > > Anyways, after fetching your PR and rebasing on that branch, the > > build is successful. > > > > Nevertheless, I had to fix/consolidate many POM files that contained > > a slew of duplicate declarations (the "dependency management" is > > done at the highest possible level, to ensure version consistency). > > Also, please use the same formatting rules as in existing files (in > > POM files, the indentation is 2 spaces). > > > > And there was this old issue that the "<artifactId>" should contain > > the name of the top-level package, i.e. "math4", not "math". > > > > I've updated the feature branch with those changes. Please rebase. > > > > I've not yet looked at the code, but a question arose from looking at > > the dependencies: What is "jfreechart" used for in the "examples"? > > I've just updated the "k-means" example, removing the GUI along > > the way. In general, I think that the example applications should > > follow the KISS principle (which here translates to: Only write to the > > console or to files). Since we don't intend to write full-fledged > > applications, building/testing should be as smooth as possible: GUIs > > entail unnecessary hassle for someone working from a remote > > (text) terminal. > > > > > Please find the log below. Kindly let me know once the build is > > successful. > > > The command was "*mvn clean verify apache-rat:check checkstyle:check > > > pmd:check spotbugs:check javadoc:javadoc*". > > > > As Alex noted, you should ensure that the build is successful with > > the supported version of the JDK (i.e. Java 8 currently). > > [If you encounter problems with a later version, it's always nice to > > file a JIRA report, but fixing such issues is probably low priority.] > > > > Regards, > > Gilles > > > > [1] > > https://github.com/apache/commons-math/blob/7a6c35b7396dbf0fb06cde5c29ce405821416d68/pom.xml#L66 > > > > > > > > > ... > > > main: > > > [INFO] Executed tasks > > > [INFO] > > > [INFO] <<< maven-javadoc-plugin:3.2.0:javadoc (default-cli) < > > > generate-sources @ commons-math4-legacy <<< > > > [INFO] > > > [INFO] > > > [INFO] --- maven-javadoc-plugin:3.2.0:javadoc (default-cli) @ > > > commons-math4-legacy --- > > > [INFO] No previous run data found, generating javadoc. > > > [INFO] > > > 19 errors > > > [INFO] > > > ------------------------------------------------------------------------ > > > [INFO] Reactor Summary for Apache Commons Math 4.0-SNAPSHOT: > > > [INFO] > > > [INFO] Apache Commons Math ................................ SUCCESS [ > > > 11.692 s] > > > [INFO] Miscellaneous core classes ......................... SUCCESS [ > > > 34.790 s] > > > [INFO] Artificial neural networks ......................... SUCCESS [ > > > 26.235 s] > > > [INFO] Transforms ......................................... SUCCESS [ > > > 29.626 s] > > > [INFO] genetic algorithm .................................. SUCCESS [ > > > 34.566 s] > > > [INFO] Exception classes (Legacy) ......................... SUCCESS [ > > > 25.376 s] > > > [INFO] Miscellaneous core classes (Legacy) ................ SUCCESS [ > > > 37.143 s] > > > [INFO] Apache Commons Math (Legacy) ....................... FAILURE > > [02:31 > > > min] > > > [INFO] Example applications ............................... SKIPPED > > > [INFO] SOFM ............................................... SKIPPED > > > [INFO] SOFM: Chinese Rings ................................ SKIPPED > > > [INFO] SOFM: Traveling Salesman Problem ................... SKIPPED > > > [INFO] K-Means ............................................ SKIPPED > > > [INFO] K-Means: Image Clustering .......................... SKIPPED > > > [INFO] examples-genetic-algorithm ......................... SKIPPED > > > [INFO] examples-ga-math-functions ......................... SKIPPED > > > [INFO] examples-ga-tsp .................................... SKIPPED > > > [INFO] > > > ------------------------------------------------------------------------ > > > [INFO] BUILD FAILURE > > > [INFO] > > > ------------------------------------------------------------------------ > > > [INFO] Total time: 05:51 min > > > [INFO] Finished at: 2022-01-30T11:35:44+05:30 > > > [INFO] > > > ------------------------------------------------------------------------ > > > [ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:javadoc (default-cli) > > > on project commons-math4-legacy: An error has occurred in Javadoc report > > > generation: > > > [ERROR] Exit code: 1 - > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\fitting\leastsquares\LevenbergMarquardtOptimizer.java:60: > > > error: attribute border for table only accepts "" or "1", use CSS > > instead: > > > BORDER > > > [ERROR] * <table style="text-align: center; background-color: #E0E0E0" > > > border="0" width="80%" cellpadding="10" summary="MINPACK redistribution > > > policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\fitting\leastsquares\LevenbergMarquardtOptimizer.java:60: > > > error: attribute not supported in HTML5: width > > > [ERROR] * <table style="text-align: center; background-color: #E0E0E0" > > > border="0" width="80%" cellpadding="10" summary="MINPACK redistribution > > > policy"> > > > [ERROR] > > > ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\fitting\leastsquares\LevenbergMarquardtOptimizer.java:60: > > > error: attribute not supported in HTML5: cellpadding > > > [ERROR] * <table style="text-align: center; background-color: #E0E0E0" > > > border="0" width="80%" cellpadding="10" summary="MINPACK redistribution > > > policy"> > > > [ERROR] > > > ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\fitting\leastsquares\LevenbergMarquardtOptimizer.java:60: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table style="text-align: center; background-color: #E0E0E0" > > > border="0" width="80%" cellpadding="10" summary="MINPACK redistribution > > > policy"> > > > [ERROR] > > > ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\linear\RealLinearOperator.java:41: > > > error: attribute not supported in HTML5: name > > > [ERROR] * <dt><a name="BARR1994">Barret et al. (1994)</a></dt> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerIntegrator.java:65: > > > error: attribute border for table only accepts "" or "1", use CSS > > instead: > > > BORDER > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0" summary="odex > > > redistribution policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerIntegrator.java:65: > > > error: attribute not supported in HTML5: width > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0" summary="odex > > > redistribution policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerIntegrator.java:65: > > > error: attribute not supported in HTML5: cellpadding > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0" summary="odex > > > redistribution policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerIntegrator.java:65: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0" summary="odex > > > redistribution policy"> > > > [ERROR] > > > ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\sampling\FieldStepNormalizer.java:45: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="1" style="text-align: center" summary="Examples > > > (step size = 0.5)"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\sampling\StepNormalizer.java:43: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="1" style="text-align: center" summary="Examples > > > (step size = 0.5)"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\stat\ranking\NaturalRanking.java:44: > > > error: attribute not supported in HTML5: cellpadding > > > [ERROR] * <table border="1" cellpadding="3" summary="Examples"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\stat\ranking\NaturalRanking.java:44: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="1" cellpadding="3" summary="Examples"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\package-info.java:130: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="1" style="text-align: center" summary="Fixed > > Step > > > Integrators"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\package-info.java:141: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="1" style="text-align: center" summary="Adaptive > > > Stepsize Integrators"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerStepInterpolator.java:45: > > > error: attribute border for table only accepts "" or "1", use CSS > > instead: > > > BORDER > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0;" summary="odex > > > redistribution policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerStepInterpolator.java:45: > > > error: attribute not supported in HTML5: width > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0;" summary="odex > > > redistribution policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerStepInterpolator.java:45: > > > error: attribute not supported in HTML5: cellpadding > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0;" summary="odex > > > redistribution policy"> > > > [ERROR] ^ > > > [ERROR] > > > > > C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\src\main\java\org\apache\commons\math4\legacy\ode\nonstiff\GraggBulirschStoerStepInterpolator.java:45: > > > error: attribute not supported in HTML5: summary > > > [ERROR] * <table border="0" width="80%" cellpadding="10" > > > style="text-align: center; background-color: #E0E0E0;" summary="odex > > > redistribution policy"> > > > [ERROR] > > > ^ > > > [ERROR] > > > [ERROR] Command line was: cmd.exe /X /C ""C:\Program > > > Files\jdk-11.0.12\bin\javadoc.exe" @options @packages" > > > [ERROR] > > > [ERROR] Refer to the generated Javadoc files in > > > > > 'C:\Personal\Work\opensource\apache-commons-maths\commons-math\commons-math-legacy\target\site\apidocs' > > > dir. > > > [ERROR] > > > [ERROR] -> [Help 1] > > > [ERROR] > > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > > -e > > > switch. > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > > [ERROR] > > > [ERROR] For more information about the errors and possible solutions, > > > please read the following articles: > > > [ERROR] [Help 1] > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > > [ERROR] > > > [ERROR] After correcting the problems, you can resume the build with the > > > command > > > [ERROR] mvn <args> -rf :commons-math4-legacy > > > > > > > > > >P.S. I'll stop trying to "rebase" the feature branch on the current > > > >state of "master" because I stumble on the same conflict every > > > >time (on the "pom.xml" file)... > > > --This will be helpful to accelerate the further development of the GA > > > module. The rebase and merging process is consuming lots of additional > > time. > > > > > > > > > Thanks & Regards > > > --Avijit Basak > > > > > > On Sun, 30 Jan 2022 at 21:27, Gilles Sadowski <gillese...@gmail.com> > > wrote: > > > > > > > Hello. > > > > > > > > Le dim. 30 janv. 2022 à 13:43, Avijit Basak <avijit.ba...@gmail.com> a > > > > écrit : > > > > > > > > > > Hi All > > > > > > > > > > I have taken a fresh clone of the feature branch > > > > "feature__MATH-1563__genetic_algorithm" from apache's repository and > > > > executed the build. The build failed without my changes added to it. > > The > > > > summary report is attached herewith. Kindly look into it and do the > > needful. > > > > > > > > There is no attachment (I think that the ML manager strips those). > > > > Please copy/paste the relevant part of the console log (or provide > > > > a link to it). > > > > > > > > Thanks, > > > > Gilles > > > > > > > > P.S. I'll stop trying to "rebase" the feature branch on the current > > > > state of "master" because I stumble on the same conflict every > > > > time (on the "pom.xml" file)... > > > > > > > > >> [...] > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
