Hi, I've completed the task of refactoring all complex operations to static functions and it has been merged to the complex-gsoc-2022 branch. Thank you for all the help to make this happen.
I wanted to talk about the next task and get some inputs from all of you on how to start. Now, I'm going to be working on complex list and matrix support. I have already begun working on this which can be seen in my github branch [1]. Right now, my work is based on the idea of a mutable list representation of a set of complex numbers (List<Complex>) using a backing double[] for storage. I know Matt mentioned using Buffers as well and so I was hoping if you can give a little more detail about this. If there are any other suggestions, please let me know. Thanks, Sumanth [1] https://github.com/sumanth-rajkumar/commons-numbers/tree/NUMBERS-186.complex_list_and_matrix_support On Tue, 12 Jul 2022 at 10:03, Sumanth Rajkumar <rajkumar.suma...@gmail.com> wrote: > Hi, > > I committed my changes to the test classes into the opened PR and I think > it ran the checks by itself without needing your approval. > > Please let me know if there's anything else I need to change. > > Thanks, > > Sumanth > > On Mon, Jul 11, 2022, 7:45 PM Alex Herbert <alex.d.herb...@gmail.com> > wrote: > >> On Mon, 11 Jul 2022 at 22:56, Gilles Sadowski <gillese...@gmail.com> >> wrote: >> >> > Le lun. 11 juil. 2022 à 20:03, Sumanth Rajkumar >> > <rajkumar.suma...@gmail.com> a écrit : >> > > >> > > Hi, >> > > >> > > I have finished updating the test classes, but I am encountering a >> > problem >> > > in the ComplexEdgeCaseTest class. >> > > >> > > private static void assertComplex(double a, double b, >> > > String name, >> UnaryOperator<Complex> >> > > operation, >> > > >> ComplexUnaryOperator<ComplexDouble> >> > > operation2, >> > > double x, double y, long >> maxUlps) { >> > > } >> > > >> > > >> > > I added my ComplexUnaryOperator as a parameter and am getting the >> error >> > of >> > > having more than 7 parameters in this method. >> > > Is there anything I can do? >> > >> > Assuming that the error is raised by "CheckStyle" (?), this check can >> > be disabled >> > on a class by class basis in this configuration file: >> > src/main/resources/checkstyle/checkstyle-suppressions.xml >> > >> >> It may be a PMD error too [1]. The PMD error can be suppressed using the >> file: >> >> src/main/resources/pmd/pmd-ruleset.xml >> >> However in Numbers there is a checkstyle suppression for ParameterNumber >> but no suppressions for PMD for ExcessiveParameterList, so you may not >> need >> this. >> >> Alex >> >> [1] >> >> https://pmd.github.io/latest/pmd_rules_apex_design.html#excessiveparameterlist >> >
