I should have added "RESULT" in the subject which I am doing now just for simpler search in the mailbox archive.
Gary On 2022/09/28 19:32:50 Gary Gregory wrote: > This VOTE passes with the following +1s: > > - Bruno Kinoshita > - Alex Herbert > - Gary Gregory > > Gary > > > On Wed, Sep 28, 2022 at 3:31 PM Gary Gregory <garydgreg...@gmail.com> wrote: > > > My +1 > > > > Gary > > > > > > On Wed, Sep 28, 2022 at 8:25 AM Alex Herbert <alex.d.herb...@gmail.com> > > wrote: > > > >> Verified the src and binary tar.gz checksums. > >> > >> Built from the src.tar.gz using: > >> > >> mvn install site > >> > >> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > >> Maven home: /usr/local/apache-maven-3 > >> Java version: 11.0.16, vendor: Ubuntu, runtime: > >> /usr/lib/jvm/java-11-openjdk-amd64 > >> Default locale: en_GB, platform encoding: UTF-8 > >> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family: > >> "unix" > >> > >> Built from the git tag using: > >> > >> mvn verify site > >> > >> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > >> Maven home: /usr/local/apache-maven-3 > >> Java version: 1.8.0_333, vendor: Oracle Corporation, runtime: > >> /usr/lib/jvm/jdk1.8.0_333/jre > >> Default locale: en_GB, platform encoding: UTF-8 > >> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family: > >> "unix" > >> > >> Checked the site reports on the local build. > >> > >> Changes: > >> > >> The report has 'Bump ...' for dependency changes. These are mainly for > >> test > >> and build plugins. The only runtime dependency change is: > >> Bump commons-lang3 3.11 -> 3.12.0. Thanks to Gary Gregory. > >> > >> In the 1.9.0 changes report these version change items were prefixed with > >> [test], [build]. That helped to show that these do not affect use of the > >> binary. I think that changes to a runtime dependency should be highlighted > >> differently in the changes report. So perhaps keep the format as is but > >> when the lang version is changed (the only runtime dependency) then this > >> should be prefixed, or highlighted somehow, in the changes report. > >> > >> JIRA report: > >> > >> This has some fixes not associated with a release. This requires reopening > >> the ticket, updating the version number for the fix, and closing. It is a > >> pain but currently the report shows these at the top and so changes are > >> not > >> chronological. > >> > >> Javadoc, crossref > >> > >> OK > >> > >> Tests > >> > >> StringSubstitutorTest.testReplace_JiraText178_WeirdPatterns3 > >> > >> This is skipped as it is disabled. But the corresponding Jira ticket is > >> marked as fixed. When I remove the disabled tag then the test passes in > >> this class and the class that inherits from it. > >> > >> Coverage > >> > >> This is very high. However looking at the lowest coverage classes show > >> some > >> areas for improvement. There are some methods not executed > >> (WordUtils.isDelimiter (deprecated)) and some with only edge case coverage > >> (StringSubstitutor.checkCyclicSubstitution). Since the coverage is > >> generally very good then the jacoco rules could be changed to require 100% > >> method coverage and a higher coverage of branch conditions. This would > >> spot > >> any obviously untested code. > >> > >> Checkstyle, spotbugs > >> > >> OK > >> > >> JApiCmp > >> > >> I checked for @since tags on the new API. > >> > >> This inner class does not have a since tag: > >> org.apache.commons.text.numbers.DoubleFormat$Builder > >> The outer class does so this may not matter depending on the convention > >> used. > >> > >> PMD > >> > >> A few minor issues. > >> > >> CPD > >> > >> Only known duplicates from deprecated classes. > >> > >> Tag List > >> > >> Only some notes about escaping HTML. This may be an ongoing issue. > >> > >> > >> [X ] +1 Release these artifacts > >> > >> Alex > >> > >> > >> On Tue, 27 Sept 2022 at 15:22, Gary Gregory <garydgreg...@gmail.com> > >> wrote: > >> > >> > We need another PMC review please. > >> > > >> > Gary > >> > > >> > On Sat, Sep 24, 2022, 11:13 Gary Gregory <garydgreg...@gmail.com> > >> wrote: > >> > > >> > > We have fixed a few bugs and added some enhancements since Apache > >> Commons > >> > > Text 1.9 was released, so I would like to release Apache Commons Text > >> > > 1.10.0. > >> > > > >> > > Apache Commons Text 1.10.0 RC1 is available for review here: > >> > > https://dist.apache.org/repos/dist/dev/commons/text/1.10.0-RC1 > >> (svn > >> > > revision 56967) > >> > > > >> > > The Git tag commons-text-1.10.0-RC1 commit for this RC is > >> > > 9397c1cdce7e78ffb3f53267d47c857d54c45d1c which you can browse here: > >> > > > >> > > > >> > > >> https://gitbox.apache.org/repos/asf?p=commons-text.git;a=commit;h=9397c1cdce7e78ffb3f53267d47c857d54c45d1c > >> > > You may checkout this tag using: > >> > > git clone https://gitbox.apache.org/repos/asf/commons-text.git > >> > > --branch commons-text-1.10.0-RC1 commons-text-1.10.0-RC1 > >> > > > >> > > Maven artifacts are here: > >> > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/orgapachecommons-1595/org/apache/commons/commons-text/1.10.0/ > >> > > > >> > > These are the artifacts and their hashes: > >> > > > >> > > #Release SHA-512s > >> > > #Sat Sep 24 10:57:06 EDT 2022 > >> > > Apache Commons > >> > > > >> > > >> Text-1.10.0.spdx.rdf.xml=88d3a92119ba4b16bfb18085ebc174d5fd1b9e3ea07a1f74c472b6f025c9e1563b3085076fc792323c798d5a621c41df671dfb684e433b09d8d2b61b16ede0b2 > >> > > > >> > > > >> > > >> commons-text-1.10.0-bin.tar.gz=4c5e1b9c8430d5e198c666ebda094dda0fdf6bd62a06884c35d07cbe53f6156dc0a6d46ff8b00e9c01079b908ea5636d3888d8efc703afc5afdcc1cdb5c5af2c > >> > > > >> > > > >> > > >> commons-text-1.10.0-bin.zip=2936964b0e989eca9253bb5823c54bdf0896c83b281b3267ff908950c82d6b667dc2b281e2f602f5c508dd3bdc9066206ffc676dd5c97ec2f36db10c64683d0a > >> > > > >> > > > >> > > >> commons-text-1.10.0-bom.json=76f6d29781a0fe14a82ed72f881dbd082c1fb98d64dfcdbd3cbd1bd39efab8cf010af0aa135152b6dc6de10fce8b1db84a4fd3748ada5d1dc56954a6c8418433 > >> > > > >> > > > >> > > >> commons-text-1.10.0-bom.xml=3863afe601c2522e84b19c964a5717a39885b3f659eb829a7cd02f48546b85cf810a4032f351750d22cf5b19a277b7b9b9434d02d0e6620e6fb7ee7b7447f881 > >> > > > >> > > > >> > > >> commons-text-1.10.0-javadoc.jar=93565e9e2ab48d5a72b4bc5b39eb4c5be56daa8421b584b26c9e3823012507f465ac8914fce96b23b123474dd61aa97c56b506f584fe935acaf9072359c3039b > >> > > > >> > > > >> > > >> commons-text-1.10.0-sources.jar=fcc30d2bd6c39c0802a386125faf00b1948ab10385705183b551822ca1f01a0e508f1ff227f7b6ed54868492b51e64ea75581cdadd0fe5de2bae310506054b4d > >> > > > >> > > > >> > > >> commons-text-1.10.0-src.tar.gz=6bf2dc7dda4429cb1b9ba3a4d383c1d9ffabd5ff35a0adc55216e7cf4c532e51b2b012c9b0f3ea859cd32aef75e05547d892301f34f304a0bfd27c39a28fe04f > >> > > > >> > > > >> > > >> commons-text-1.10.0-src.zip=f1f959528b00baef4b2f109d650bfbcc28de08acf856be34f5e723357f5aaf065e623cbc204d2e5e7f54fa8277c205066e28525c048efea8f63c2662ea05e3d2 > >> > > > >> > > > >> > > >> commons-text-1.10.0-test-sources.jar=96d1e20e6665113f5c7f4f332f0a863673e4e84fd88125dcd49fba40a4d6e96224da0654f156b4cf01fb1279226b5a213f8cf63f529fcfc2473759f96e85ba0c > >> > > > >> > > > >> > > >> commons-text-1.10.0-tests.jar=f5f643f54afb6356b01df78aba5965a605162d86fb02d7da0f346f4c12e9323804ad0e22cd07ac6ebeea4bdd50b86540a83029f8e88b374984d5e8b883836b24 > >> > > > >> > > > >> > > I have tested this with 'mvn -V -Duser.name=$my_apache_id > >> > > -Dcommons_release_plugin_version=$commons_release_plugin_version > >> > -Prelease > >> > > -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using: > >> > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > >> > > Maven home: /usr/local/Cellar/maven/3.8.6/libexec > >> > > Java version: 1.8.0_345, vendor: Homebrew, runtime: > >> > > /usr/local/Cellar/openjdk@8 > >> > > /1.8.0+345/libexec/openjdk.jdk/Contents/Home/jre > >> > > Default locale: en_US, platform encoding: UTF-8 > >> > > OS name: "mac os x", version: "12.6", arch: "x86_64", family: "mac" > >> > > > >> > > Darwin **** 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 > >> PDT > >> > > 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 > >> > > > >> > > Details of changes since 1.9 are in the release notes: > >> > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/commons/text/1.10.0-RC1/RELEASE-NOTES.txt > >> > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/commons/text/1.10.0-RC1/site/changes-report.html > >> > > > >> > > Site: > >> > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/commons/text/1.10.0-RC1/site/index.html > >> > > (note some *relative* links are broken and the 1.10.0 directories > >> are > >> > > not yet created - these will be OK once the site is deployed.) > >> > > > >> > > JApiCmp Report (compared to 1.9): > >> > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/commons/text/1.10.0-RC1/site/japicmp.html > >> > > > >> > > RAT Report: > >> > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/commons/text/1.10.0-RC1/site/rat-report.html > >> > > > >> > > KEYS: > >> > > https://downloads.apache.org/commons/KEYS > >> > > > >> > > Please review the release candidate and vote. > >> > > This vote will close no sooner than 72 hours from now. > >> > > > >> > > [ ] +1 Release these artifacts > >> > > [ ] +0 OK, but... > >> > > [ ] -0 OK, but really should fix... > >> > > [ ] -1 I oppose this release because... > >> > > > >> > > Thank you, > >> > > > >> > > Gary Gregory, > >> > > Release Manager (using key 86fdc7e2a11262cb) > >> > > > >> > > For following is intended as a helper and refresher for reviewers. > >> > > > >> > > Validating a release candidate > >> > > ============================== > >> > > > >> > > These guidelines are NOT complete. > >> > > > >> > > Requirements: Git, Java, Maven. > >> > > > >> > > You can validate a release from a release candidate (RC) tag as > >> follows. > >> > > > >> > > 1) Clone and checkout the RC tag > >> > > > >> > > git clone https://gitbox.apache.org/repos/asf/commons-text.git > >> --branch > >> > > commons-text-1.10.0-RC1 commons-text-1.10.0-RC1 > >> > > cd commons-text-1.10.0-RC1 > >> > > > >> > > 2) Check Apache licenses > >> > > > >> > > This step is not required if the site includes a RAT report page which > >> > you > >> > > then must check. > >> > > > >> > > mvn apache-rat:check > >> > > > >> > > 3) Check binary compatibility > >> > > > >> > > Older components still use Apache Clirr: > >> > > > >> > > This step is not required if the site includes a Clirr report page > >> which > >> > > you then must check. > >> > > > >> > > mvn clirr:check > >> > > > >> > > Newer components use JApiCmp with the japicmp Maven Profile: > >> > > > >> > > This step is not required if the site includes a JApiCmp report page > >> > which > >> > > you then must check. > >> > > > >> > > mvn install -DskipTests -P japicmp japicmp:cmp > >> > > > >> > > 4) Build the package > >> > > > >> > > mvn -V clean package > >> > > > >> > > You can record the Maven and Java version produced by -V in your VOTE > >> > > reply. > >> > > To gather OS information from a command line: > >> > > Windows: ver > >> > > Linux: uname -a > >> > > > >> > > 5) Build the site for a single module project > >> > > > >> > > Note: Some plugins require the components to be installed instead of > >> > > packaged. > >> > > > >> > > mvn site > >> > > Check the site reports in: > >> > > - Windows: target\site\index.html > >> > > - Linux: target/site/index.html > >> > > > >> > > -the end- > >> > > > >> > > > >> > > >> > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
