Hello CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before shipping 1.10.0 IMO - missing default - broken serialization of class CSVFormat
I raised these issues in CSV-302. The serialization issue is caught by Revapi. I had suggested to include Revapi in the project (CSV-303) or alternatively add revapi and drop clirr in commons-parent but that more or less fell on deaf ears. mvn org.revapi:revapi-maven-plugin:check [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3.560 s [INFO] Finished at: 2022-10-17T11:30:21+02:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.14.7:check (default-cli) on project commons-csv: The following API problems caused the build to fail: [ERROR] java.field.serialVersionUIDUnchanged: field org.apache.commons.csv.CSVFormat.serialVersionUID: The class changed in an incompatible way with regards to serialization but the serialVersionUID field stayed unchanged. This might be ok and/or desired but is suspicious. https://revapi.org/revapi-java/differences.html#java.field.serialVersionUIDUnchanged [ERROR] java.method.exception.checkedRemoved: method java.util.List<org.apache.commons.csv.CSVRecord> org.apache.commons.csv.CSVParser::getRecords(): Method no longer throws checked exceptions: java.io.IOException. https://revapi.org/revapi-java/differences.html#java.method.exception.checkedRemoved Also noticed that class DuplicateHeaderMode and method CSVFormat.getDuplicateHeaderMode() are incorrectly annotated with "@since 1.9.0". Both are new in version 1.10.0. My vote is -1 assuming I am allowed to vote. Kind regards, Markus From: Gary Gregory <garydgreg...@gmail.com> Sent: Sunday, October 16, 2022 14:48 To: Commons Developers List <dev@commons.apache.org> Subject: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1 To: dev@commons.apache.org We have fixed a few bugs and added some enhancements since Apache Commons CSV 1.9.0 was released, so I would like to release Apache Commons CSV 1.10.0. Apache Commons CSV 1.10.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC1 (svn revision 57404) The Git tag commons-csv-1.10.0-RC1 commit for this RC is 1bd1fd8e6065da9d07b5a3a1723b059246b14001 which you can browse here: https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=1bd1fd8e6065da9d07b5a3a1723b059246b14001 You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch commons-csv-1.10.0-RC1 commons-csv-1.10.0-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1600/org/apache/commons/commons-csv/1.10.0/ These are the artifacts and their hashes: #Release SHA-512s #Sun Oct 16 08:32:39 EDT 2022 Apache\ Commons\ CSV-1.10.0.spdx.rdf.xml=c8cf7495637ce5282c72aa8e8ef4b93f206fbbdf21c7b337a34daa3b89af9816073d0185118cab4cdbed5104cc7f090e81efb614594079b02829c96829fe8aeb commons-csv-1.10.0-bin.tar.gz=5b0ff3f5cc4aeff6c2aa2c11e92ea8b1b1fbbcd098ba79d97bcfd9af3ea08a9ebc922e5237bda8abcb238eb0d2fe7a5ef27534d0d796a1fc77691684a698f3d1 commons-csv-1.10.0-bin.zip=a52caa6ccda5b830c133c965fd6843d8f960e1ce3ef83decf5435022481746093cf8b4308c1fded21a168b751724b4a9f5e72f3eca34381828968bff89e7239b commons-csv-1.10.0-bom.json=0e3e6652e520afb697461a3f6b33458dc8ef1dd157c2b1442664b8f12f7504226916e64960cea5cc92dd2b923d18047ed921be60eb7febfbeffc8ac3e3254fc0 commons-csv-1.10.0-bom.xml=91e494b94eea35ee7d85c8d8dbdc5029f981e0c5a8b1aae2b0f3cd77d1cea0fb0fc8c857d18d41ca055d12c4c4eb1adf70582f178a88751b836861c3286283db commons-csv-1.10.0-javadoc.jar=719656f5399e0889af2e8b40f49458d0dec6e8ae85413f36caa2187235c68d9e42502bf07c66c0bcc7c5c3427bc0aac51f9897581842d303501bbff5ec73bdc0 commons-csv-1.10.0-sources.jar=c78c8fa112ef35d6d6c061b05e08816ce516a3acd56d720c59dbdaeb9d1202b16294233bd2aa2fac91cfa759456f8d7e08951876d85decdf0b8fb215a8e31754 commons-csv-1.10.0-src.tar.gz=a0d3a7aedab567aaa32a3dd1ceddeff412e686f3fd2b0805993db7e3dd4804b4d5d59e70f1500f23e8d0ba6531832e9f20d0c298bd443d9825724d5d1b1c87b3 commons-csv-1.10.0-src.zip=5cbdbcf367c9dd78e76228817592d70378b3cd8d919fdcd7df5c3eb2d7ebd8bd47fbb17376a631efb640be4115d42d3cc7aafa866bfefdfe073d5a4fcf625e0b commons-csv-1.10.0-test-sources.jar=0d77c791934609b176457df5c60fdd5bfa3c6f392375adef81e5e7cd31de7fb25bd91b0bbe60a9ff46acb62efc2a33660adff24850370b7546a71374aa267f94 commons-csv-1.10.0-tests.jar=9a08e4d2ec865d9e1dafc01e4ee58804490b2d50f886bac47a5235581077b31a15dda5b3f8f2adb5a70be8794cca886126d980d6d3722eec2e10471fc24e1940 I have tested this with 'mvn' and 'mvn -V -Duser.name=$my_apache_id -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using: Darwin *** 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /usr/local/Cellar/maven/3.8.6/libexec Java version: 1.8.0_345, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk@8/1.8.0+345/libexec/openjdk.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "12.6", arch: "x86_64", family: "mac" Details of changes since 1.9.0 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC1/site/index.html (note some *relative* links are broken and the 1.10.0 directories are not yet created - these will be OK once the site is deployed.) JApiCmp Report (compared to 1.9.0): https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC1/site/japicmp.html RAT Report: https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC1/site/rat-report.html KEYS: https://downloads.apache.org/commons/KEYS Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Gary Gregory, Release Manager (using key 86fdc7e2a11262cb) For following is intended as a helper and refresher for reviewers. Validating a release candidate ============================== These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch commons-csv-1.10.0-RC1 commons-csv-1.10.0-RC1 cd commons-csv-1.10.0-RC1 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package You can record the Maven and Java version produced by -V in your VOTE reply. To gather OS information from a command line: Windows: ver Linux: uname -a 5) Build the site for a single module project Note: Some plugins require the components to be installed instead of packaged. mvn site Check the site reports in: - Windows: target\site\index.html - Linux: target/site/index.html -the end- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
