On Wed, 2 Nov 2022 at 11:54, sebb <seb...@gmail.com> wrote:
>
> On Wed, 2 Nov 2022 at 11:44, Alex Herbert <alex.d.herb...@gmail.com> wrote:
> >
> > On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski <gillese...@gmail.com> wrote:
> > >
> > > Hi Alex.
> > >
> > > Do I understand correctly that the change below may introduce dependencies
> > > on modules that are not actually used in the [Geometry] code?
> > >
> > > Regards,
> > > Gilles
> >
> > The git diff does not show that this change is in the
> > dependencyManagement section.
>
> Huh? AFAICT it *is* in the dependencyManagement section:
>
> https://github.com/apache/commons-geometry/blob/6de48f6df9d956500b0267a3c919b8c6d7cf0dbb/pom.xml#L143

To clarify my point: the plain text diff sent to the mailing list did
not show enough of the relevant section around the change to make it
clear it is in the dependencyManagement section. It starts with:

@@ -138,28 +138,10 @@
   <dependencies>
       <dependency>

So reading the diff you may think the change was in the dependencies section.

To see the correct location you have to look at the file to see the
surrounding tag for change location as:

<dependencyManagement>
  <dependencies>
    <dependency>

Alex

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to