+1 Build passes for java8, java11, (nit) java17 on mac M1 is a bit funky because they moved homebrew from /usr/local/homebrew -> /opt/homebrew, and java17 actually realizes that the M1 is an arm processor. The earlier versions of java do not.
Signatures Check out. Reports Surefire, Rat, JaCoCo, japicmp, Checkstyle, SpotBugs, CPD, and PMD all look reasonable -------------------------------------- We have fixed a few bugs and made some enhancements since Apache Commons Crypto 1.1.0 was released, so I would like to release Apache Commons Crypto 1.2.0. Apache Commons Crypto 1.2.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1 (svn revision 59345) The Git tag commons-crypto-1.2.0-RC1 commit for this RC is d1ca10a92a61257ac225c6c1f8881af0aef91309 which you can browse here: https://gitbox.apache.org/repos/asf?p=commons-crypto.git;a=commit;h=d1ca10a92a61257ac225c6c1f8881af0aef91309 You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-crypto.git --branch commons-crypto-1.2.0-RC1 commons-crypto-1.2.0-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1616/org/apache/commons/commons-crypto/1.2.0/ These are the artifacts and their hashes: #Release SHA-512s #Sat Jan 14 17:16:26 EST 2023 commons-crypto-1.2.0-bin.tar.gz=fb9084a5d9adcd4df606c7deb9396fa5693443b6a91be12f5de17e4281d3e7d89b526dc6ebd7991569894bde2f9fb67036eb78504cb4fa26fae9b7a99d082051 commons-crypto-1.2.0-bin.zip=c78d2d2f3343c0402d1e55301d9a85036550b937512024470ee9843f1cbcf6d28a49e2f1e2b2a6856c26898da61eec5739cfefac237abbf2e8735f0f69bb42bf commons-crypto-1.2.0-bom.json=104a6c100cad2e896836815449c0d74da1ab469e7260f0911ddf2230b6f89392ef4768768493192999b60dd36ffcca48483110508cee4c44e3a924fcbbe59a60 commons-crypto-1.2.0-bom.xml=bf30ab0f46f0356d64ed4b3b39574c1dcc351b14d0f12233e63f1b8e9d04fb5fe223e2625dd118be65013682b9a64382fee29e56713a8bd949501b3f49bfd639 commons-crypto-1.2.0-javadoc.jar=4a1944faca7aa68716bb2c55fafe0e10eff435c9ff10b1f3ad2cc96948c57ea0c7648b1fc6cb3d56a23d67f6f91b9e61d8b1eeb092e3c13335b2adba07e8540f commons-crypto-1.2.0-sources.jar=234fd31696293390c1e0f02a1b9362079452b5524bdb148fb635734f14c39d61c92a96799e2751d3291e33fee6cc2d469545b8b45d44486d9d5edf2b87ebf4c5 commons-crypto-1.2.0-src.tar.gz=4ebbdc3eddedaeb142c2d4b30fe640b70f95d785d290b96422d7bd64f8179899c573a88e23048bf061e58d52c13f79ae6180fb694c2f86ec584b419847dbb381 commons-crypto-1.2.0-src.zip=2ec1c7510893c6274722f587e6e5a2d3ec3ad4f077727be22fd85b13a18304feab5a93a5c57c82ffe9c8f2f8763b64452256e4053b5e186c68e620bf698ae857 commons-crypto-1.2.0-test-sources.jar=d2a0218e8b60ca0f2f0b7b11d79636ec3d8c0f226b4a405d5f15a12f5128aeed65105b7b81310ada097fad85580276912910757b5672b66c2dacae7520a2506d commons-crypto-1.2.0-tests.jar=8439dd580eb36ba270da12c59c19c600ae1e2ea375e47b7bcf4855ac13a8baad833ee49d0796f804853a6639895c531318977c9f6b4760d3fc8617893a8d9b3f org.apache.commons_commons-crypto-1.2.0.spdx.json=31a4fa548308eda4c1798c9a5f6b0fef5c5034cb09586099c93dd93978e95fda81043faa45af237e5289ff9ecdccff8ec0b18af13e7ffc43095a79d3f217cb8b I have tested this with 'mvn -V -Prelease -Ptest-deploy clean package site deploy' using: Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29) Maven home: /usr/local/Cellar/maven/3.8.7/libexec Java version: 1.8.0_352, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk@8/1.8.0+352/libexec/openjdk.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "13.1", arch: "x86_64", family: "mac" Darwin gdg-mac-mini.local 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64 Non-macOS native binaries were built on Windows 10 using Docker. Details of changes since 1.1.0 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1/site/index.html (note some *relative* links are broken and the 1.2.0 directories are not yet created - these will be OK once the site is deployed.) JApiCmp Report (compared to 1.1.0): https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1/site/japicmp.html RAT Report: https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1/site/rat-report.html KEYS: https://downloads.apache.org/commons/KEYS Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Gary Gregory, Release Manager (using key 86fdc7e2a11262cb) For following is intended as a helper and refresher for reviewers. Validating a release candidate ============================== These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1a) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-crypto.git --branch commons-crypto-1.2.0-RC1 commons-crypto-1.2.0-RC1 cd commons-crypto-1.2.0-RC1 1b) Download and unpack the source archive from: https://dist.apache.org/repos/dist/dev/commons/crypto/1.2.0-RC1/source 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Older components still use Apache Clirr: This step is not required if the site includes a Clirr report page which you then must check. mvn clirr:check Newer components use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package You can record the Maven and Java version produced by -V in your VOTE reply. To gather OS information from a command line: Windows: ver Linux: uname -a 5) Build the site for a single module project Note: Some plugins require the components to be installed instead of packaged. mvn site Check the site reports in: - Windows: target\site\index.html - Linux: target/site/index.html -the end- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org