+1 - looks good to me
> On Sep 27, 2023, at 7:03 AM, Bruno Kinoshita <brunodepau...@gmail.com> wrote: > > [X] +1 Release these artifacts > > The website change page date needs to be updated for the latest release, > but that can be done after the release. > > On Tue, 26 Sept 2023 at 21:51, Phil Steitz <pste...@apache.org> wrote: > >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Pool 2.11.1 was released, so I would like to release >> Apache Commons Pool 2.12.0. >> >> Apache Commons Pool 2.12.0 RC5 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5 (svn >> revision 64211) >> >> The Git tag commons-pool-2.12.0-RC5 commit for this RC is >> commons-pool-1.12.0-RC5 which you can browse here: >> >> https://github.com/apache/commons-pool/releases/tag/commons-pool-2.12.0-RC5 >> You may checkout this tag using: >> git clone https://gitbox.apache.org/repos/asf/commons-pool.git >> --branch >> commons-pool-2.12.0-RC5 commons-pool-2.12.0-RC5 >> >> Maven artifacts are here: >> >> >> https://repository.apache.org/content/repositories/orgapachecommons-1659/org/apache/commons/commons-pool2/2.12.0/ >> >> These are the artifacts and their hashes: >> >> #Release SHA-512s >> #Tue Sep 26 11:50:36 MST 2023 >> >> commons-pool2-2.12.0-bom.xml=46f6d5da5c530b482bf3d23d53c337f28507d9d27b5f4ef56dc3523fe27c24833de0e05d20460a1c0b77dd5569f1d1207e9d95bbf5332ae103503abf00a0bdfb >> >> commons-pool2-2.12.0-bin.zip=08ea2579002276e6e5ff576bd3cfc1b4b29e1ecd471c6a38b263f57c9a887a158eee62a6ff3093e6017cb947409194dd1d7a9d681ae32588eb241404da3796e0 >> >> commons-pool2-2.12.0-tests.jar=697ac4c33eca5067dedfbc6b7f656aa230ba71908aed6450ca49a0419aad0f588bd0a238c9e7198999265b79c7fab2e760f3575bdad7ff13109ef2aaf72c36a4 >> >> commons-pool2-2.12.0-sources.jar=470d45652b9c63e92feb26c517edfd324878214a87faeee79e70772fd6ead1553aaa362b209dc1cb950cc144004223b186e142810a72be0caa839e87446999b6 >> >> commons-pool2-2.12.0-src.zip=c09424e2a6209adf0e1660de421c35c3b80c395a5d4ef30e6ff58c499b5768cde15e508f858dffc0dfde1c9a3d18d5d7681d67ca5c796d99e5922c712889e195 >> >> commons-pool2-2.12.0-bom.json=f2ac923db32811d691c304ab8425fff757ebe3102cbacafad7244dc3f5d742e1376ba7fb906b177a626dd766f49baa2da977efb260e3d66aa8dd8b3034954276 >> >> org.apache.commons_commons-pool2-2.12.0.spdx.json=2e8e3f1f2aa69abc7c49b0487960159cf6690e5de4ad74706c47e00f55479490b7ed31a478b82f6b51c94ef23501fc8850432d00d7364180bba5486d63cd33bc >> >> commons-pool2-2.12.0-src.tar.gz=fefb22459519b92712a9e5178099d19cc7fc8a5b07f633387c11f5b30d86ae8f73e237728be08a2705cf56f986be5a51c11a084b01224e5a0c9ccf7b34dc6258 >> >> commons-pool2-2.12.0-javadoc.jar=a4b3df904311892327d210f0c507b4c9cba1e2289071a87d873ea72f60052a5658728f6412715c6e1cb0528f8df15cd9c74fe20d173b17cc887120048334a119 >> >> commons-pool2-2.12.0-test-sources.jar=b93d6529527029f26aa51bf451e2c0250e5e20c7c884b51d2c1377d3e58c218679ba56f87e10bd1062fbc87bb8db3a2bfe98c5b54910566a57260ab77f530482 >> >> commons-pool2-2.12.0-bin.tar.gz=3d75b997287df339acfd76662cf6e4b645b10fff825bffc58dd2238dbaaccf7b81c61aa59ada6f667a3f29d9db0730e34b25526f7d309db36361e4d1e8c6ec70 >> >> I have tested the build of this release candidate with >> >> mvn clean package site >> under >> openjdk version "17.0.8.1" 2023-08-24 >> OpenJDK Runtime Environment (build 17.0.8.1+1-Ubuntu-0ubuntu120.04) >> OpenJDK 64-Bit Server VM (build 17.0.8.1+1-Ubuntu-0ubuntu120.04, mixed >> mode, sharing) >> >> openjdk version "11.0.20.1" 2023-08-24 >> OpenJDK Runtime Environment (build 11.0.20.1+1-post-Ubuntu-0ubuntu120.04) >> OpenJDK 64-Bit Server VM (build 11.0.20.1+1-post-Ubuntu-0ubuntu120.04, >> mixed mode, sharing) >> >> openjdk version "1.8.0_382" >> OpenJDK Runtime Environment (build 1.8.0_382-8u382-ga-1~20.04.1-b05) >> OpenJDK 64-Bit Server VM (build 25.382-b05, mixed mode) >> >> Using >> Apache Maven 3.9.3 (21122926829f1ead511c958d89bd2f672198ae9f) >> Linux 5.15.0-83-generic #92~20.04.1-Ubuntu SMP >> >> And >> openjdk version "20.0.1" 2023-04-18 >> OpenJDK Runtime Environment Homebrew (build 20.0.1) >> OpenJDK 64-Bit Server VM Homebrew (build 20.0.1, mixed mode, sharing) >> Darwin Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; >> root:xnu-8796.141.3~6/RELEASE_X86_64 >> >> I have also tested the compiled jar against DBCP 2.10 and run soak and >> performance tests using Commons Performance. Performance was not >> significantly different from earlier 2.x versions for the tested workloads. >> >> Details of changes since 2.11.1 are in the release notes: >> >> >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/RELEASE-NOTES.txt >> >> >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/changes-report.html >> >> Site: >> >> >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/index.html >> (note some *relative* links are broken and the 2.12.0 directories are >> not yet created - these will be OK once the site is deployed.) >> >> JApiCmp Report (compared to 2.11.1): >> >> >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/japicmp.html >> >> RAT Report: >> >> >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/rat-report.html >> >> KEYS: >> https://downloads.apache.org/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner than 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thanks! >> Phil Steitz, >> Release Manager (using key 4E2DDD47E19863BB87211544CD3038FEF07D567E) >> >> The following is intended as a helper and refresher for reviewers. >> >> Validating a release candidate >> ============================== >> >> These guidelines are NOT complete. >> >> Requirements: Git, Java, Maven. >> >> You can validate a release from a release candidate (RC) tag as follows. >> >> 1a) Clone and checkout the RC tag >> >> git clone https://gitbox.apache.org/repos/asf/commons-pool.git --branch >> commons-pool-2.12.0-RC5 commons-pool-2.12.0-RC5 >> cd commons-pool-2.12.0-RC5 >> >> 1b) Download and unpack the source archive from: >> >> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/source >> >> >> 2) Check binary compatibility >> >> Review the JApiCmp report linked above >> >> 3) Build the package and site from the unpacked source distribution or tag >> >> mvn -V clean package site >> >> You can record the Maven and Java version produced by -V in your VOTE >> reply. >> To gather OS information from a command line: >> Windows: ver >> Linux: uname -a >> >> 4) bonus points: Test that the packaged jar works as expected in >> applications. If you have applications that use [pool], install the 2.12.0 >> jar locally and test against it. >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
