Following Rob's suggestion, I migrated FTPSClientTest from
@Parameterized to @Nested
The result so far can be found here:
https://github.com/apache/commons-net/pull/227/commits/b14ee39cca486bda106758a48d31c91ad52d0d83
Basically the test methods were moved from FTPSClientTest.java [1] to
AbstractFtpsTest.java [2]. The two @Parameterized values are then
injected using @Nested.
The behaviour in maven is exactly the same as before. The behaviour in
Eclipse bugs me a little, instead of asking both nested tests by
default, it asks which one should be executed. But that seems to be the
case with @Nested tests in general.
[1]
https://github.com/apache/commons-net/blob/b14ee39cca486bda106758a48d31c91ad52d0d83/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java
[2]
https://github.com/apache/commons-net/blob/b14ee39cca486bda106758a48d31c91ad52d0d83/src/test/java/org/apache/commons/net/ftp/AbstractFtpsTest.java
Any feedback is welcome. I personally feel like this test case is a bit
too complex to be easily grokked, and perhaps it can be improved a bit
more after the JUnit migration.
I'll try to tackle some more tests at some point this week.
Best,
Elric
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
