On Tue, 2 Apr 2024 at 15:40, mogasale.tech <mogasale.t...@gmail.com> wrote: > > Thanks for the response. > > I have thoughts about this change not only within DomainValidator, but also > to make it configurable at the two classes (EmailValidator and > UrlValidator) where DomainValidator#isValid is consumed today. > > I'll give it a try in a few days.
In the same way that Local Addresses are allowed (or not), it might make sense to allow the DomainValidator to be constructed with a flag to skip TLD validation. This might simplify the calling code. > Regards, > Ram > > On Sun, 31 Mar 2024 at 08:16, Gary Gregory <garydgreg...@gmail.com> wrote: > > > Ram, > > > > Feel free to provide a PR on GitHub. > > > > Gary > > > > On Sat, Mar 30, 2024, 10:43 PM mogasale.tech <mogasale.t...@gmail.com> > > wrote: > > > > > Hi Team, > > > > > > Here is the proposal to make DomainValidator#isValidDomainSyntax method > > in > > > commons-validator library public, currently it is package private. Below > > > are the reasoning behind the same. > > > > > > 1. In many use cases, products just need to validate the syntax of the > > > given input. Conformation to the IANA maintained generic TLDs is not > > > required in such cases. So, DomainValidator#isValid cannot be used as it > > is > > > strict about Generic TLDs. > > > > > > 2. Products end up implementing their own regex based implementations. > > This > > > is not only error prone, but also wastage of developer productivity to > > > write and maintain the boilerplate code for something already handled by > > > this library. > > > > > > Kindly consider the same and do the needful. > > > > > > Regards, > > > Ram > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
