Hi Phil, I think those are OK, and likely old (or new but more on this later): The default goal in this POM (clean apache-rat:check javadoc:javadoc checkstyle:check verify japicmp:cmp) does not run SpotBugs or PMD; but the SpotBugs report is still generated. This means GH CI and and default builds don't fail for SpotBugs.
Cleaning up SpotBugs and PMD issue is on my long term to-do list, then SpotBugs and PMD checks can be added to the default goal. It's likely that as SpotBugs versions have been bumped new types of issues are detected. HTH, Gary On 2024/06/10 00:46:46 Phil Steitz wrote: > There are a bunch of findbugs errors reported. Is this expected? > > Phil > > On Fri, Jun 7, 2024 at 5:40 AM Gary Gregory <ggreg...@apache.org> wrote: > > > We have fixed a few bugs and added enhancements since Apache Commons > > Net 3.11.0 was released, so I would like to release Apache Commons Net > > 3.11.1. > > > > Apache Commons Net 3.11.1 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1 (svn > > revision 69595) > > > > The Git tag commons-net-3.11.1-RC1 commit for this RC is > > 0505563df6664a8c5b5fad6897cd373aba809c64 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-net.git;a=commit;h=0505563df6664a8c5b5fad6897cd373aba809c64 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-net.git > > --branch <https://gitbox.apache.org/repos/asf/commons-net.git--branch> > > commons-net-3.11.1-RC1 commons-net-3.11.1-RC1 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1738/commons-net/commons-net/3.11.1/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Fri Jun 07 12:26:06 UTC 2024 > > > > commons-net-3.11.1-bin.tar.gz=90c1e62d8fe1d8c26588fbfefeb41f6ef16a349b8851e75297363c7d2eca5cb27d313a11e2f532f9b9c8b2790f1b9636f39c5fd563a6e9403ac6363415245bd9 > > > > commons-net-3.11.1-bin.zip=e2e378d247ab4a1260d01c18579abe247bcca05246b9340edfb07f7bf5aa216ea745f590696bda9d43806b273ef8f8e73ed7a60b4f47f77dab45a5f657467fba > > > > commons-net-3.11.1-bom.json=f954bd7d2560a423b2c93f78d92cc6b658c5fab66465bc0adb3e455385448f8b32f0319c229703645a8ad9cae88dccb689e6783e85d4f450671d7563a485ac3d > > > > commons-net-3.11.1-bom.xml=0937d4448e3c52987ab3ba9268ebe68ab85e748a394d1c75efa6682dd265bd159c7f6c8e0bbb10fa61f2f13675ebb8d7753b2fefadee96be1e4c9da391bf9aff > > > > commons-net-3.11.1-javadoc.jar=fe46639c1df071ec1e4f785ff4c2b55f8b0604a3d90b9395852f9be4a4b57a9e490ab985a79fc29a6e287944a2cfc2352837685eb01795f5647ec5c95b6cbd43 > > > > commons-net-3.11.1-sources.jar=9aa64b66154ee1775d9af6b8d99e9cb771c5234545df716e2273eb9a050cd683dda3d8520b660207f23229ccaf08533f6339ebfbb75210d0ff43df41d7419e33 > > > > commons-net-3.11.1-src.tar.gz=0999067cc73cb0e0ab4940302180a0afa998b37c51f93c1c744bf1d346d14c89283166a665283d98200e98f0b8c39854f17493890d49ddad5769c4deb49de37e > > > > commons-net-3.11.1-src.zip=6820a334da2b4144acbd73e8f254bcd39cf46d83ecd4974d11e97c84fb573d78132546ac05530b3a88f7db3e59a3660600f3436716cd76c44016c797302ec8a9 > > > > commons-net-3.11.1-test-sources.jar=0697dfe901f6f2f307c3ea813c22181c90b0b762549cc8a9e3e0394dadb2b5868e46b307630608a34df973ca5d6e346eb36823ae2a58d8d62d20ad47be3463dd > > > > commons-net-3.11.1-tests.jar=be5614c73ca8fe1f78ce58cc735ee34a32698ec956407562383b8257eb19a8211c0ca448507f4bfaf1bb85bbc6b3bb189edbbbfb71b5d92b5e113af579c74810 > > > > commons-net-examples-3.11.1.jar=160512e72ae002e4214a23d0d20694295b8265a19a7889183e130d0b9e17f4a5edb22b12d3492e505269e3427935ff17d0f3f29557dd09103b68473df4648566 > > > > commons-net-ftp-3.11.1.jar=1fc341b3ef5759858b355495d1d07fe8fdc4f6773d4619db6b67f86c39e60e7f25e208e2a4da7fa306172b7aca557c1a521144329cd6059ceaab603b7944f552 > > > > commons-net_commons-net-3.11.1.spdx.json=0ccf4994b061451d93d1225a8960483bbfcf5e87d03caac8ed0d7e7a6e815d07b34d76c401156b2246829a30554dcb61419a6766b35451ad12a6251fa0f1eef9 > > > > I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P > > jacoco -P japicmp clean package site deploy' using: > > > > openjdk version "21.0.3" 2024-04-16 > > OpenJDK Runtime Environment Homebrew (build 21.0.3) > > OpenJDK 64-Bit Server VM Homebrew (build 21.0.3, mixed mode, sharing) > > > > Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0) > > Maven home: /usr/local/Cellar/maven/3.9.7/libexec > > Java version: 21.0.3, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk@21/21.0.3/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac" > > > > Darwin **** 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:09:52 > > PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64 > > > > Details of changes since 3.11.0 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1/site/changes-report.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1/site/index.html > > (note some *relative* links are broken and the 3.11.1 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 3.11.0): > > > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1/site/japicmp.html > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-net.git --branch > > commons-net-3.11.1-RC1 commons-net-3.11.1-RC1 > > cd commons-net-3.11.1-RC1 > > > > 1b) Download and unpack the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1/source > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
