Thanks Phil, I'll look into these issues. Gary
On Sat, Jun 15, 2024 at 1:01 PM Phil Steitz <phil.ste...@gmail.com> wrote: > > +1 > > Build, sigs, notes, all look good to me. > > Tested on > apache-maven-3.9.3 > Java version: 17.0.11, vendor: Ubuntu, runtime: > /usr/lib/jvm/java-17-openjdk-amd64 > OS name: "linux", version: "5.15.0-107-generic", arch: "amd64", family: > "unix" > > Some non-blocker comments: > > 0) There are quite a few javadoc warnings > 1) SpotBugs errors should be suppressed or addressed > 2) Checkstyle report is strangely wonky. RAT is fine and headers look fine > to me, but Checkstyle is, um, confused > > Phil > > On Fri, Jun 14, 2024 at 7:49 PM Gary Gregory <ggreg...@apache.org> wrote: > > > We have fixed a few bugs and added enhancements since Apache Commons > > Collections 4.5.0-M1 was released, so I would like to release Apache > > Commons Collections 4.5.0-M2. > > > > Apache Commons Collections 4.5.0-M2 RC1 is available for review here: > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1 > > (svn revision 69753) > > > > The Git tag commons-collections-4.5.0-M2-RC1 commit for this RC is > > c92828a71367a4208d380e614f633d0196b5ad27 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=c92828a71367a4208d380e614f633d0196b5ad27 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-collections.git > > --branch > > <https://gitbox.apache.org/repos/asf/commons-collections.git--branch> > > commons-collections-4.5.0-M2-RC1 > > commons-collections-4.5.0-M2-RC1 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1743/org/apache/commons/commons-collections4/4.5.0-M2/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sat Jun 15 02:29:00 UTC 2024 > > > > commons-collections4-4.5.0-M2-bin.tar.gz=277ec5079fe3d0e9783aaa49a9eb6e486b2f917f54ea369d6c3a0bfd38f4b0525f57ead9d2004615f459b0a3a1a0217d00f3638a2171afd504feb185992a6e38 > > > > commons-collections4-4.5.0-M2-bin.zip=95fb06b1ab80d0769acc41ceef3349c2efe14513bf4ebb66b000b4781264c5054b04b275133b989f3080291deca3a8561b228910bb55588bbcdcaf47f938164c > > > > commons-collections4-4.5.0-M2-bom.json=a7cbaa38b9ba7e674f694ca0f71a45b9e787cf4ad42d7a2e220f36030dd7d3307c12f99f16dcbde7c8457cd76d554b5619d0fa88849f58096a86b71ee9077028 > > > > commons-collections4-4.5.0-M2-bom.xml=11f612198e324da771eb6496a2fad59e884d368a0c008b5fa7943fceea1014a14dfdf7c7e49f23b87f67b6fc6fae01ed84fe4b842862461222e7f0b8d7e61aae > > > > commons-collections4-4.5.0-M2-javadoc.jar=8069b3bf23ddec37257147c73b03ed965f70afce721821294dea4c22b68b21963690409ad15f7e3eeb2b72b1151b5e4ca95f81c3c4a7a750716989269ab02890 > > > > commons-collections4-4.5.0-M2-sources.jar=97a7ad53ea5539cc8730f3697f6114daa59f52f48ab913e1187ba5a595a7bdc7bd3a8d440efd9e6975d833b094debf3e62faf98818706fd9cad08b8fc34f4837 > > > > commons-collections4-4.5.0-M2-src.tar.gz=8fe8c0c158254f44c7cc8744c9969e9a32fcd0642f56598c7a942da07c9fc88a6916cf07174e73f9a88f157fa0dbd56e829522f34b0c63ee129ebf923bcc42f7 > > > > commons-collections4-4.5.0-M2-src.zip=32b8db011cd1c7a3b83b6ea2bb2b5c795636cf6ccaa83e277ecf1eb27f50469f3c5d3e1eedae606be190fad8baa1d5c04599701a6d84b52c0b56d44d7d1ec71d > > > > commons-collections4-4.5.0-M2-test-sources.jar=6dc1719b80f800be57dccfd05e959bc0f9f22aac0c9aca84c74b68d623e1bcae10346162347206fd28d66e4c8364d56c4e4998a4820898a259ca758c3054830d > > > > commons-collections4-4.5.0-M2-tests.jar=65b9e8f72a00daa586bba62e818aac348679f9afda5bcbf95c10d47e9d5e5e65c27518565ada2af56146ff09ccc1f5ad940eb123c3fb9c53bcc8624db3254e1c > > > > org.apache.commons_commons-collections4-4.5.0-M2.spdx.json=d3e8455335a09f92b7b1c470104384080d933d5f64d5fe96fde31645a1fef3168a5ce1f5f3be8a1f4da6318a11996a959c2485654b6ec9423d26c8347ff2294b > > > > > > I have tested this with 'mvn' and 'mvn -e -V -Prelease -Ptest-deploy > > -P jacoco -P japicmp clean package site deploy' using: > > > > openjdk version "17.0.11" 2024-04-16 > > OpenJDK Runtime Environment Homebrew (build 17.0.11+0) > > OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing) > > > > Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0) > > Maven home: /usr/local/Cellar/maven/3.9.7/libexec > > Java version: 17.0.11, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac" > > > > Darwin **** 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:09:52 > > PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64 > > > > Details of changes since 4.4 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1/site/changes-report.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1/site/index.html > > (note some *relative* links are broken and the 4.5.0-M2 > > directories are not yet created - these will be OK once the site is > > deployed.) > > > > JApiCmp Report (compared to 4.4): > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1/site/japicmp.html > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-collections.git > > --branch > > <https://gitbox.apache.org/repos/asf/commons-collections.git--branch> > > commons-collections-4.5.0-M2-RC1 > > commons-collections-4.5.0-M2-RC1 > > cd commons-collections-4.5.0-M2-RC1 > > > > 1b) Download and unpack the source archive from: > > > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.5.0-M2-RC1/source > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
