On Fri, Oct 25, 2024 at 11:25 PM Emmanuel Bourg <ebo...@apache.org> wrote: > > Le 25/10/2024 à 12:57, Gary Gregory a écrit : > > -1, please revert and stop inlining Commons methods all over itself. > > Could you elaborate why in this case please? Vetos to code changes have > to be technically justified. You can't just say that you don't like them. >
That's exactly backwards. Code changes have to be technically justified. The responsibility is on the proposer, not the vetoer, to demonstrate that the change os worthwhile. Code changes are not accepted by default unless there's good and valid reason for them. If you can't get even one committer to +1 a PR thgen it doesn't meet the threshold for merging. -- Elliotte Rusty Harold elh...@ibiblio.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
