Hi. Le lun. 18 nov. 2024 à 11:05, Henri Biestro <hen...@apache.org> a écrit : > > > > > > It does not make sense to me to add any dependency (regardless of > > size) for such minor simplifications. > > > > [ +1 ] > > Adding a dependency should be done out of functional necessity, not to avoid > one-liners
The discussion is on the _principle_ of "code reuse". So 1. I agree that a one-liner cannot be considered to break this principle, and 2. the awaited policy would concern non-obvious code beyond a certain numbers of statements (e.g. some functionality for which we wouldn't want to have a security fix applied somewhere and then wonder if the same bug exists in another component; because of copy/paste). > and shading should only be used as the last possible solution. > In the context of the commons projects, the former should be carefully > weighted (adding dependency) and the latter (shading) not even considered. I must be missing something; I thought that "shading" was an acceptable trade-off combining two requirements: 1. Avoid dependency 2. Avoid "manual" copy/paste At some point in the Commons history, "shading" was highly recommended! Regards, Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org