Hi Gary,

On 22.11.2024 18:26, Gary Gregory wrote:
The point of the Log4j update and the release is to show that version of
Log4j is formally tested and supported.

This removes any guessing game for users.

I totally understand the spirit of providing a list of the most recent compatible dependencies at each release. What I don't understand is why are we making a release just to update the dependencies?

Below I added the output of `diffoscope commons-logging-1.3.4.jar commons-logging-1.3.5.jar`. There are NO changes in the classes, except the version number in `module-info.class`.

Piotr

├── META-INF/MANIFEST.MF
│ @@ -1,28 +1,28 @@
│  Manifest-Version: 1.0
│  Created-By: Apache Maven Bundle Plugin 5.1.9
│  Build-Jdk-Spec: 17
│  Specification-Title: Apache Commons Logging
│  Specification-Version: 1.3
│  Specification-Vendor: The Apache Software Foundation
│  Implementation-Title: Apache Commons Logging
│ -Implementation-Version: 1.3.4
│ +Implementation-Version: 1.3.5
│  Implementation-Vendor: The Apache Software Foundation
│  Automatic-Module-Name: org.apache.commons.logging
│  Bundle-Description: Apache Commons Logging is a thin adapter allowing co
│   nfigurable bridging to other,    well-known logging systems.
│  Bundle-DocURL: https://commons.apache.org/proper/commons-logging/
│  Bundle-License: https://www.apache.org/licenses/LICENSE-2.0.txt
│  Bundle-ManifestVersion: 2
│  Bundle-Name: Apache Commons Logging
│  Bundle-SymbolicName: org.apache.commons.commons-logging
│  Bundle-Vendor: The Apache Software Foundation
│ -Bundle-Version: 1.3.4
│ -Export-Package: org.apache.commons.logging;version="1.3.4",org.apache.co
│ - mmons.logging.impl;version="1.3.4"
│ +Bundle-Version: 1.3.5
│ +Export-Package: org.apache.commons.logging;version="1.3.5",org.apache.co
│ + mmons.logging.impl;version="1.3.5"
│  Import-Package: javax.servlet;version="[2.1.0,5.0.0)";resolution:=option
│ al,org.apache.avalon.framework.logger;version="[4.1.3,4.1.5]";resolutio
│ n:=optional,org.apache.log;version="[1.0.1,1.0.1]";resolution:=optional
│ ,org.apache.log4j;version="[1.2.15,2.0.0)";resolution:=optional,org.apa
│ che.logging.log4j;version="[2.0,4.0)";resolution:=optional,org.apache.l
│ ogging.log4j.spi;version="[2.0,4.0)";resolution:=optional,org.apache.lo
│ gging.log4j.util;version="[2.0,4.0)";resolution:=optional,org.slf4j;ver
├── META-INF/maven/commons-logging/commons-logging/pom.xml
│ ├── META-INF/maven/commons-logging/commons-logging/pom.xml
│ │ @@ -23,58 +23,58 @@
│ │        tests are executed in the "integration-test" phase rather than the │ │        "test" phase. Please run "mvn integration-test" to run the full suite of
│ │        available unit tests.
│ │      -->
│ │    <parent>
│ │      <groupId>org.apache.commons</groupId>
│ │      <artifactId>commons-parent</artifactId>
│ │ -    <version>72</version>
│ │ +    <version>78</version>
│ │    </parent>
│ │    <modelVersion>4.0.0</modelVersion>
│ │    <groupId>commons-logging</groupId>
│ │    <artifactId>commons-logging</artifactId>
│ │    <name>Apache Commons Logging</name>
│ │ -  <version>1.3.4</version>
│ │ +  <version>1.3.5</version>
│ │    <description>Apache Commons Logging is a thin adapter allowing configurable bridging to other,
│ │      well-known logging systems.</description>
│ │ <url>https://commons.apache.org/proper/commons-logging/</url>
│ │    <properties>
│ │ <animal-sniffer.signature>java18</animal-sniffer.signature>
│ │ <commons.logging.javaversion>1.8</commons.logging.javaversion>
│ │ <maven.compiler.source>${commons.logging.javaversion}</maven.compiler.source> │ │ <maven.compiler.target>${commons.logging.javaversion}</maven.compiler.target>
│ │ <commons.componentid>logging</commons.componentid>
│ │ <commons.module.name>org.apache.commons.logging</commons.module.name>
│ │ - <commons.release.version>1.3.4</commons.release.version>
│ │ - <commons.release.next>1.3.5</commons.release.next>
│ │ - <commons.bc.version>1.3.3</commons.bc.version>
│ │ + <commons.release.version>1.3.5</commons.release.version>
│ │ + <commons.release.next>1.3.6</commons.release.next>
│ │ + <commons.bc.version>1.3.4</commons.bc.version>
│ │ <commons.release.isDistModule>true</commons.release.isDistModule>
│ │      <commons.jira.id>LOGGING</commons.jira.id>
│ │      <commons.jira.pid>12310484</commons.jira.pid>
│ │      <!-- The RC version used in the staging repository URL. -->
│ │      <commons.rc.version>RC1</commons.rc.version>
│ │      <skipSurefireReport>true</skipSurefireReport>
│ │      <!-- Since version 3.2 additional classpath dependencies are allowed. -->
│ │ <commons.failsafe.version>3.2.1</commons.failsafe.version>
│ │      <!-- Allow default test run order to be changed -->
│ │ <failsafe.runorder>filesystem</failsafe.runorder>
│ │ -    <log4j2.version>2.23.1</log4j2.version>
│ │ +    <log4j2.version>2.24.2</log4j2.version>
│ │      <logback.version>1.3.14</logback.version>
│ │      <slf4j.version>2.0.16</slf4j.version>
│ │ <findsecbugs.version>1.13.0</findsecbugs.version>
│ │ <commons.osgi.import>javax.servlet;version=&quot;[2.1.0, 5.0.0)&quot;;resolution:=optional, │ │ org.apache.avalon.framework.logger;version=&quot;[4.1.3, 4.1.5]&quot;;resolution:=optional, │ │        org.apache.log;version=&quot;[1.0.1, 1.0.1]&quot;;resolution:=optional, │ │        org.apache.log4j;version=&quot;[1.2.15, 2.0.0)&quot;;resolution:=optional, │ │        org.apache.logging.log4j;version=&quot;[2.0, 4.0)&quot;;resolution:=optional, │ │        org.apache.logging.log4j.spi;version=&quot;[2.0, 4.0)&quot;;resolution:=optional, │ │        org.apache.logging.log4j.util;version=&quot;[2.0, 4.0)&quot;;resolution:=optional,
│ │        org.slf4j;version=&quot;[1.7, 3)&quot;;resolution:=optional,
│ │        org.slf4j.spi;version=&quot;[1.7, 3)&quot;;resolution:=optional</commons.osgi.import> │ │ - <project.build.outputTimestamp>2024-08-16T12:44:34Z</project.build.outputTimestamp> │ │ + <project.build.outputTimestamp>2024-11-22T15:35:19Z</project.build.outputTimestamp>
│ │      <!-- JaCoCo: Don't make code coverage worse than: -->
│ │ <commons.jacoco.haltOnFailure>true</commons.jacoco.haltOnFailure>
│ │ <commons.jacoco.classRatio>0.42</commons.jacoco.classRatio>
│ │ <commons.jacoco.instructionRatio>0.52</commons.jacoco.instructionRatio>
│ │ <commons.jacoco.methodRatio>0.61</commons.jacoco.methodRatio>
│ │ <commons.jacoco.branchRatio>0.34</commons.jacoco.branchRatio>
│ │ <commons.jacoco.lineRatio>0.44</commons.jacoco.lineRatio>
│ │ @@ -201,30 +201,14 @@
│ │ <groupId>org.apache.maven.plugins</groupId>
│ │ <artifactId>maven-surefire-plugin</artifactId>
│ │          <configuration>
│ │            <skip>true</skip>
│ │          </configuration>
│ │        </plugin>
│ │        <plugin>
│ │ -        <!--
│ │ -            Many of JCL's tests use tricky techniques to place the generated │ │ -            JCL jarfiles on the classpath in various configurations. This means │ │ -            that those tests must be run *after* the "package" build phase.
│ │ -
│ │ -            Disable cobertura report generation as this does not work correctly │ │ -            with integration-tests and the normal unit tests are disabled too.
│ │ -          -->
│ │ -        <groupId>org.codehaus.mojo</groupId>
│ │ - <artifactId>cobertura-maven-plugin</artifactId>
│ │ - <version>${commons.cobertura.version}</version>
│ │ -        <configuration>
│ │ -          <skip>true</skip>
│ │ -        </configuration>
│ │ -      </plugin>
│ │ -      <plugin>
│ │          <groupId>org.moditect</groupId>
│ │ <artifactId>moditect-maven-plugin</artifactId>
│ │          <executions>
│ │            <execution>
│ │              <id>add-module-infos</id>
│ │              <configuration>
│ │                <module>
│ │ @@ -595,15 +579,15 @@
│ │        <version>4.0.1</version>
│ │        <scope>provided</scope>
│ │        <optional>true</optional>
│ │      </dependency>
│ │      <dependency>
│ │        <groupId>org.apache.commons</groupId>
│ │        <artifactId>commons-lang3</artifactId>
│ │ -      <version>3.16.0</version>
│ │ +      <version>3.17.0</version>
│ │        <scope>test</scope>
│ │      </dependency>
│ │      <dependency>
│ │        <groupId>org.apache.logging.log4j</groupId>
│ │        <artifactId>log4j-core</artifactId>
│ │        <version>${log4j2.version}</version>
│ │        <scope>test</scope>
├── META-INF/maven/commons-logging/commons-logging/pom.properties
│ @@ -1,3 +1,3 @@
│  artifactId=commons-logging
│  groupId=commons-logging
│ -version=1.3.4
│ +version=1.3.5
├── META-INF/versions/9/module-info.class
│ ├── javap -verbose -constants -s -l -private {}
│ │ @@ -1,21 +1,21 @@
│ │ -  SHA-256 checksum 1c68ffa652e91e78a866dcde089520a8db32fcd3db4ca6045a308cba36e0d121
│ │ -module org.apache.commons.logging@1.3.4
│ │ +  SHA-256 checksum ec9c5c4e8165476e9381ef017d44269bea8ab19fb3392e95f91b322944ff2b87
│ │ +module org.apache.commons.logging@1.3.5
│ │    minor version: 0
│ │    major version: 53
│ │    flags: (0x8000) ACC_MODULE
│ │    this_class: #2                          // "module-info"
│ │    super_class: #0
│ │    interfaces: 0, fields: 0, methods: 0, attributes: 1
│ │  Constant pool:
│ │     #1 = Utf8               module-info
│ │     #2 = Class              #1             // "module-info"
│ │     #3 = Utf8               org.apache.commons.logging
│ │     #4 = Module             #3             // "org.apache.commons.logging"
│ │ -   #5 = Utf8               1.3.4
│ │ +   #5 = Utf8               1.3.5
│ │     #6 = Utf8               org.apache.logging.log4j
│ │     #7 = Module             #6             // "org.apache.logging.log4j"
│ │     #8 = Utf8               org.slf4j
│ │     #9 = Module             #8             // "org.slf4j"
│ │    #10 = Utf8               avalon.framework
│ │    #11 = Module             #10            // "avalon.framework"
│ │    #12 = Utf8               java.logging
│ │ @@ -35,15 +35,15 @@
│ │    #26 = Utf8               java.base
│ │    #27 = Module             #26            // "java.base"
│ │    #28 = Utf8               Module
│ │  {
│ │  }
│ │  Module:
│ │    #4,1000                                 // "org.apache.commons.logging" ACC_SYNTHETIC
│ │ -  #5                                      // 1.3.4
│ │ +  #5                                      // 1.3.5
│ │    8                                       // requires
│ │      #7,40                                   // "org.apache.logging.log4j" ACC_STATIC_PHASE
│ │      #0
│ │      #9,40                                   // "org.slf4j" ACC_STATIC_PHASE
│ │      #0
│ │      #11,40                                  // "avalon.framework" ACC_STATIC_PHASE
│ │      #0


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to