This release vote passes with the following binding +1 votes: - Gary Gregory (ggregory) - Arnout Engelen (engelen) - Piotr P. Karwasz (pkarwasz)
Thank you all, Gary On Fri, Feb 14, 2025 at 3:36 AM Piotr P. Karwasz <pi...@mailing.copernik.eu> wrote: > > Hi Gary, > > On 13.02.2025 11:51, Piotr P. Karwasz wrote: > > Hi Gary, > > > > On 3.02.2025 00:26, Gary Gregory wrote: > >> Please review the release candidate and vote. > >> This vote will close no sooner than 72 hours from now. > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > > > > The hashes in the SBOMs do not match what is in Maven Central (e.g. > > the hash of Commons Code is wrong). Should we continue? > > Ignoring the SBOMs and irreproducible `tests` artifacts: > > - I have checked checksums and signatures. > > - I have built the artifacts and checked their reproducibility. > > - I ran the tests. This wasn't easy, since either the Jsch-based tests > failed or this one: > > VirtualProviderTestCase>AbstractProviderTestCase.runTest:293 Weak > Listener was abandoned expected:<Listener false [tru]e false> but > was:<Listener false [fals]e false> > > However, since each test succeeded at least once and Jsch is planned to > be removed[1]: > > +1, release the artifacts. > > Piotr > > PS: The Jsch-based tests failed due to the contents of my `.ssh` > directory. Probably some key format I use is not supported by the > 15-years old library. > > [1] https://issues.apache.org/jira/browse/VFS-838 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
