This vote passes with the following +1 binding votes: - Henri Biestro (henrib) - Gary Gregory (ggregory) - Rob Tompkins (chtompki)
Gary On Thu, Apr 17, 2025 at 10:23 AM Rob Tompkins <chtom...@apache.org> wrote: > > +1 all looks good. > > -Rob > > > On Apr 13, 2025, at 7:04 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > We have fixed a few bugs and added enhancements since Apache Commons > > JXPath 1.3 was released, so I would like to release Apache Commons > > JXPath 1.4.0. > > > > Apache Commons JXPath 1.4.0 RC2 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2 > > (svn revision 76234) > > > > The Git tag commons-jxpath-1.4.0-RC2 commit for this RC is > > 146f2534e885fd7085fba4bf3fb658d434416504 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-jxpath.git;a=commit;h=146f2534e885fd7085fba4bf3fb658d434416504 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-jxpath.git > > --branch commons-jxpath-1.4.0-RC2 commons-jxpath-1.4.0-RC2 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1824/commons-jxpath/commons-jxpath/1.4.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sun Apr 13 22:56:27 UTC 2025 > > commons-jxpath-1.4.0-bom.json=91035b52e7305884f1f283c54f6d3f1255cac8bdd18b62820fac07bc3e872d1b1baf9d76a14c62d94ba08fe9ca9e19222c6983cdac3b67d6eaab7b2a2056eb16 > > commons-jxpath-1.4.0-bom.xml=6f9735d831e24c0811d9aa041913e8dcb4b8492984307134582198155d503c37e0775d51eab8c9cbdfdd30638ac1522651dbe65aadd365d0074391082ce24782 > > commons-jxpath-1.4.0-javadoc.jar=1b97abd849e96d7a45ccdd69e4726b3c9c8cc34ee10dd3bea1fc1fffa8f91b586a6ec253f78dde5dcb8af7587963708dc4a377c3fe77d97cb1061d05b11e8eff > > commons-jxpath-1.4.0-sources.jar=918fd91e9a74c71ab1b0531e0013738eb78d5591debaa75323ac8d731f5845ad45657322666bc73b9640a977947321eda3c737545c0fa0c43a1f95c20bfeee95 > > commons-jxpath-1.4.0-src.tar.gz=fd18abb89fa37f6d78e906a4e65af54a4d8424949f01df1166e6ce1ef7a1938f07290bba15e14185fcdd108a4836243f94dcff77f8bbd98ae4b2c7c546607416 > > commons-jxpath-1.4.0-src.zip=3be62ff300cda63463f21015dacdd96d7574c4e391b10aeff1817050190056d98f67027e27c0fbea027dcb6b550bd11c53dc1cbf0727214ecefa3e0b40a8c05d > > commons-jxpath-1.4.0-test-sources.jar=385552bdbcd65da1c54f5150537ec123008fb9a56e1fb070f105d81b679613ce5ef4b97c2042d2f29a9d1931257b1a2d418e195774efa14edbcbb5ab3851d7c5 > > commons-jxpath-1.4.0-tests.jar=0590d15d5c120a70ad6dc8d6529bce855cbc31fd716c7df6fdb9abf25dce1052defd7365bac24820d2680f1194f1dce850ac939d05052821c717bbd7d6ba6f3a > > commons-jxpath_commons-jxpath-1.4.0.spdx.json=f569e60e85882d4bfb1134c4b0c00384daa42a272ac2d6077b9fee1d233932a9ebc6466f520298eda27c4d22167423a5fce488dd61ef9a69a09493b8473ba58b > > > > > > I have tested this with 'mvn' and 'mvn -e -V -P release -P test-deploy > > -P jacoco -P japicmp clean package site deploy' using: > > > > openjdk version "21.0.6" 2025-01-21 > > OpenJDK Runtime Environment Homebrew (build 21.0.6) > > OpenJDK 64-Bit Server VM Homebrew (build 21.0.6, mixed mode, sharing) > > > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > > Maven home: /opt/homebrew/Cellar/maven/3.9.9/libexec > > Java version: 21.0.6, vendor: Homebrew, runtime: > > /opt/homebrew/Cellar/openjdk@21/21.0.6/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "15.4", arch: "aarch64", family: "mac" > > > > Darwin ****.local 24.4.0 Darwin Kernel Version 24.4.0: Wed Mar 19 > > 21:17:35 PDT 2025; root:xnu-11417.101.15~1/RELEASE_ARM64_T6041 arm64 > > > > Docker version 28.0.4, build b8034c0 > > > > > > Details of changes since 1.3 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2/site/changes.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2/site/index.html > > (note some *relative* links are broken and the 1.4.0 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 1.3): > > > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2/site/japicmp.html > > > > Note that the above report notes several errors. > > These are considered OK for the reasons stated below. > > > > Errors reported: > > - False positive: > > org.apache.commons.jxpath.JXPathContextFactoryConfigurationError#getMessage() > > is supported through the superclass. > > - False positive: > > org.apache.commons.jxpath.JXPathException#getCause() is supported > > through the superclass. > > - False positive: > > org.apache.commons.jxpath.JXPathException#getMessage() is supported > > through the superclass. > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > The following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, and Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Download and decompress the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/jxpath/1.4.0-RC2/source > > > > 1b) Check out the RC tag from git (optional) > > > > This is optional, as a reviewer must check source distributions as a > > minimum. > > > > git clone https://gitbox.apache.org/repos/asf/commons-jxpath.git > > --branch commons-jxpath-1.4.0-RC2 commons-jxpath-1.4.0-RC2 > > cd commons-jxpath-1.4.0-RC2 > > > > 2) Checking the build > > > > All components should include a default Maven goal, such that you can > > run 'mvn' from the command line by itself. > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > This check should be included in the default Maven build, but you can > > check it with: > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > This check should be included in the default Maven build, but you can > > check it with: > > > > mvn verify -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > This check should be included in the default Maven build, but you can > > check it with: > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 4b) Check reproducibility > > > > To check that a build is reproducible, run: > > > > mvn clean verify artifact:compare -DskipTests > > -Dreference.repo=https://repository.apache.org/content/repositories/staging/ > > '-Dbuildinfo.ignore=*/*.spdx.json' > > > > Note that this excludes SPDX files from the check. > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
