My +1 Gary
On Fri, May 16, 2025 at 10:00 AM Alex Herbert <alex.d.herb...@gmail.com> wrote: > +1 > > Installed locally from the tag. Built Statistics and Lang using JDK 8 and > 21: > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > Maven home: /Users/ah403/software/apache-maven-3 > Java version: 21.0.6, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-21.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac" > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > Maven home: /Users/ah403/software/apache-maven-3 > Java version: 1.8.0_442, vendor: Temurin, runtime: > /Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "15.5", arch: "x86_64", family: "mac" > > Note: Some config changes are required in Statistics due to a new rule > added in PMD 7.10: ExhaustiveSwitchHasDefault [1]. The project currently > enforces default case statements using checkstyle but PMD now provides > checking for exhaustive switches, and those that are exhaustive with > default statements (see also NonExhaustiveSwitch [2]). I believe the > out-of-the box configuration for PMD will now detect if your switch > statements do not cover everything, and remove the need for a catch-all > default statement. > > Alex > > [1] > > https://docs.pmd-code.org/latest/pmd_rules_java_bestpractices.html#exhaustiveswitchhasdefault > [2] > > https://docs.pmd-code.org/latest/pmd_rules_java_bestpractices.html#nonexhaustiveswitch > > > > On Fri, 16 May 2025 at 13:19, Gary Gregory <garydgreg...@gmail.com> wrote: > > > We have picked up a few bug fixes since Apache Commons Parent 83 was > > released, so I would like to release Apache Commons Parent 84. > > > > Apache Commons Parent 84 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1 (svn > > revision 76860) > > > > The Git tag commons-parent-84-RC1 commit for this RC is > > 65e45324cb451ff202db4f9863289cdc0f4b9ce6 which you can browse here: > > > > > > > https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=65e45324cb451ff202db4f9863289cdc0f4b9ce6 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > --branch <https://gitbox.apache.org/repos/asf/commons-parent.git--branch > > > > commons-parent-84-RC1 commons-parent-84-RC1 > > > > Maven artifacts are here: > > > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1835/org/apache/commons/commons-parent/84/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Fri May 16 12:11:39 UTC 2025 > > > > > commons-parent-84-bom.json=9ca5ef800968c963c6e5b080c795782d7b2611a05e6bc4780a9470ce10bc2a36853ca1a0b281c672f44bba6ad501dee55d9a467a32bcc9ca20625e46db8f2a0b > > > > > commons-parent-84-bom.xml=549a6381aac9088b386634c4d9c70254d76c51184591e3682464bec5c5e8962021d307ddee5467b11f02808882bac2596abdb0f29baa3d7a2a747bf097f806bf > > > > > commons-parent-84-site.xml=07c3de38227fd28664777636162d583dc0cb5061c8133f827023ca3188b641a53ee2aed1192a8842f76071b2db8c5aeef7d4c58457c8688c89d577ae23d51a86 > > > > > commons-parent-84-src.tar.gz=75536b27321df8a86d180fcf22dab91eaedcad5ed9c1e64b57868a98022769c6a54dc3d814d07b24fb246a120f3c0116732de0bc2b4c4a2904552abcebedb95e > > > > > commons-parent-84-src.zip=2ff821e447980f4cb7e9a2b6bec390e2bb5c57327f94f148d890532c3179808dda0ebcf2fb1c981ea6414965d42ec8699536c0ce404cf97786b9e3a6a325b68d > > > > > org.apache.commons_commons-parent-84.spdx.json=f37284ea946e0bc03c177000dae7a9c2461d2d25e8ec7cea01f45c6a9250b4894fb1bd2b0144ae5fede98272e10940f948437ba37deaa86d6b4f4a3bfc1f8400 > > > > I have tested this with 'mvn' and 'mvn -e -V -P release -P test-deploy > > clean package site deploy' using: > > > > openjdk version "21.0.7" 2025-04-15 > > OpenJDK Runtime Environment Homebrew (build 21.0.7) > > OpenJDK 64-Bit Server VM Homebrew (build 21.0.7, mixed mode, sharing) > > > > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > > Maven home: /opt/homebrew/Cellar/maven/3.9.9/libexec > > Java version: 21.0.7, vendor: Homebrew, runtime: > > /opt/homebrew/Cellar/openjdk@21/21.0.7/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac" > > > > Darwin **** 24.5.0 Darwin Kernel Version 24.5.0: Tue Apr 22 19:53:27 PDT > > 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T6041 arm64 > > > > Docker version 28.0.4, build b8034c0 > > > > Details of changes since 83 are in the release notes: > > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1/RELEASE-NOTES.txt > > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1/site/changes.html > > > > Site: > > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1/site/index.html > > (note some *relative* links are broken and the 84 directories are not > > yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 83): > > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1/site/japicmp.html > > There is no repoirt since this is not a Java JAR module. > > > > RAT Report: > > > > > > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > The following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, and Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1a) Download and decompress the source archive from: > > > > https://dist.apache.org/repos/dist/dev/commons/parent/84-RC1/source > > > > 1b) Check out the RC tag from git (optional) > > > > This is optional, as a reviewer must check source distributions as a > > minimum. > > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > --branch > > commons-parent-84-RC1 commons-parent-84-RC1 > > cd commons-parent-84-RC1 > > > > 2) Checking the build > > > > All components should include a default Maven goal, such that you can run > > 'mvn' from the command line by itself. > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > you > > then must check. > > This check should be included in the default Maven build, but you can > check > > it with: > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > This step is not required if the site includes a JApiCmp report page > which > > you then must check. > > This check should be included in the default Maven build, but you can > check > > it with: > > > > mvn verify -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > This check should be included in the default Maven build, but you can > check > > it with: > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 4b) Check reproducibility > > > > To check that a build is reproducible, run: > > > > mvn clean verify artifact:compare -DskipTests -Dreference.repo= > > https://repository.apache.org/content/repositories/staging/ > > '-Dbuildinfo.ignore=*/*.spdx.json' > > > > Note that this excludes SPDX files from the check. > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > >
