The [pool] unit tests in the 2_X branch are riddled with deprecation
warnings mostly due to either changed method names or legacy time-related
methods where the non-deprecated version takes a Duration instead of a
long.  I am on the fence as to whether to fix these now or wait until the
deprecated methods are deleted in the next major release.  The reasons to
fix them now are

0) The unit tests are useful in learning how to do things. Having them full
of deprecations is not good for that purpose.

1) Unless we duplicate them all, the current tests don't test the
non-deprecated versions.

2) The implementations of the long-based methods just delegate to the
non-deprecated versions, so there is no real loss in coverage by fixing the
deprecations

wdyt?

Phil

Reply via email to