Hi Gili, On 13.08.2025 07:43, Gili Tzabari wrote: >> Since JDK 8 is not modular, it simply treats >> `module-info.class` as a regular resource. > > I was going to ask, why risk a future problem? Couldn't you just > configure BND to place this file under META-INF/versions/9/?
That’s a good question. Do you foresee any potential future issues with BND’s current behavior? To clarify my earlier message: Apache Commons does *not* use BND to generate JPMS descriptors: it uses Moditect, which places them in `META-INF/versions`. However, other projects (e.g., Log4j) do use BND, and unless I’m mistaken, BND always places the descriptor at the root of the JAR. If you identify any problems with this approach, it may be worth opening an issue with BND [1]. > Have all the other commons-math4 artifacts been updated this way? If so, > we should be done. Since Commons Math is a multi-module Maven project, updating one artifact means all others should also be updated. However, it’s still worth double-checking the correctness of the generated descriptors. There might be some problems related to the `transitive` (which needs to be set manually) or `static` modifiers. Piotr References: [1] https://github.com/bndtools/bnd --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
