On Wed, Nov 12, 2025 at 3:07 PM Peter Burka <[email protected]> wrote: > > It shouldn't hold up the release, but these "IllegalArgument 30 hours out > of range" errors suggest a bug somewhere.
Yep, I'm cutting RC2. > > I think the error is being thrown from > https://github.com/apache/commons-lang/blob/626e7e93aea200e6910be5597ac30de602649745/src/main/java/org/apache/commons/lang3/time/GmtTimeZone.java#L46 > > Possibly the machine has some non-standard UTC+30 timezone defined? > > But the test isn't expecting IllegalArgumentExceptions: it handles > ParseException. Presumably user code is also only expecting > ParseExceptions. I think somewhere along the call chain someone ought to > catch the IllegalArgumentException and wrap it in a ParseException. Or the > GmtTimeZone should be more lenient about unexpected values. Thank you for looking into it. There is something funky in this one test that is rare to reproduce locally for me, but it happens more frequently on the GitHub CI, but only on Java 25 and only on Windows and macOS, not Ubuntu. Gary > > Peter > > On Wed, Nov 12, 2025 at 12:54 PM Gary Gregory <[email protected]> > wrote: > > > On Wed, Nov 12, 2025, 12:18 Phil Steitz <[email protected]> wrote: > > > > > Three runs on a "real" machine with same ubuntu and jdk ran with no > > errors > > > in about 5 mins per run. > > > > > > > Thank you Phil! I'll roll RC2 shortly. > > > > Gary > > > > > > > On Tue, Nov 11, 2025 at 4:26 PM Phil Steitz <[email protected]> > > wrote: > > > > > > > Could be the hokey setup of the build machine that I have been using. > > it > > > > is a "repurposed" Intel Macbook running Ubuntu. I will try with > > another > > > > machine tonight. > > > > > > > > On Tue, Nov 11, 2025 at 4:19 PM Gary Gregory <[email protected]> > > > > wrote: > > > > > > > >> Some tests takes a different amount of time depending on the Java > > > version, > > > >> which contain varying amounts of time zones defined. Some of the tests > > > end > > > >> up showing that we or the JRE can't parse what it formats, sometimes > > > >> randomly, which is likely a bug in the tests. On GitHub, a macOS Java > > > 25 > > > >> build takes about 12 mins and 9 mins on Ubuntu. Not sure that helps. > > > >> > > > >> Gary > > > >> > > > >> On Tue, Nov 11, 2025, 17:14 Phil Steitz <[email protected]> > > wrote: > > > >> > > > >> > Strange two runs from the downloaded tag both succeeded, but took a > > > >> *very* > > > >> > long time. Like 39 minutes. > > > >> > > > > >> > *Tests **run: 2323*, Failures: 0, Errors: 0, *Skipped: 6*, Time > > > elapsed: > > > >> > 2037 s -- in org.apache.commons.lang3.time. > > > >> > *FastDateParser_TimeZoneStrategyTest* > > > >> > > > > >> > On Tue, Nov 11, 2025 at 12:12 PM Phil Steitz <[email protected] > > > > > > >> > wrote: > > > >> > > > > >> > > openjdk 25 2025-09-16 > > > >> > > > > > >> > > OpenJDK Runtime Environment (build 25+36-Ubuntu-124.04.2) > > > >> > > > > > >> > > OpenJDK 64-Bit Server VM (build 25+36-Ubuntu-124.04.2, mixed mode, > > > >> > sharing) > > > >> > > > > > >> > > > > > >> > > Default locale: en_US, platform encoding: UTF-8 > > > >> > > > > > >> > > > > > >> > > I am in the wonderful AZ time zone, which is currently line MST. > > > >> > > > > > >> > > > > > >> > > Let me see if I can reproduce. The error came at the end of a > > loop > > > >> over > > > >> > > jdks. I did not get the error on jdk 11, 17 or 21. > > > >> > > > > > >> > > > > > >> > > Phil > > > >> > > > > > >> > > On Tue, Nov 11, 2025 at 11:43 AM Gary Gregory < > > > [email protected] > > > >> > > > > >> > > wrote: > > > >> > > > > > >> > >> On Tue, Nov 11, 2025 at 1:30 PM Phil Steitz < > > [email protected] > > > > > > > >> > >> wrote: > > > >> > >> > > > > >> > >> > I also ran into these tests failures on ubuntu with jdk 25 > > > >> > >> > > > > >> > >> > [ERROR] Errors: > > > >> > >> > > > > >> > >> > [ERROR] > > > >> > >> > > > >> > > > > >> > > > > > FastDateParser_TimeZoneStrategyTest.testTimeZoneStrategy_TimeZone:139->testTimeZoneStrategyPattern_TimeZone_getAvailableIDs:224 > > > >> > >> > » IllegalArgument 30 hours out of range > > > >> > >> > > > > >> > >> > [ERROR] > > > >> > >> > > > >> > > > > >> > > > > > FastDateParser_TimeZoneStrategyTest.testTimeZoneStrategy_TimeZone:139->testTimeZoneStrategyPattern_TimeZone_getAvailableIDs:224 > > > >> > >> > » IllegalArgument 30 hours out of range > > > >> > >> > > > >> > >> Thank Phil, not seen that one before! > > > >> > >> > > > >> > >> I wonder if we can reproduce this from a test in GitHub or for > > all > > > >> > >> devs. What is your local Locale and time zone? Are you on Java 25 > > > or > > > >> > >> 25.0.1? > > > >> > >> > > > >> > >> Gary > > > >> > >> > > > >> > >> > > > > >> > >> > [INFO] > > > >> > >> > > > > >> > >> > [ERROR] Tests run: 44513, Failures: 0, Errors: 2, Skipped: 14 > > > >> > >> > > > > >> > >> > > > > >> > >> > Phil > > > >> > >> > > > > >> > >> > On Tue, Nov 11, 2025 at 11:24 AM Gary Gregory < > > > >> [email protected] > > > >> > > > > > >> > >> > wrote: > > > >> > >> > > > > >> > >> > > Adding [CANCEL] to subject. > > > >> > >> > > > > > >> > >> > > Gary > > > >> > >> > > > > > >> > >> > > On Tue, Nov 11, 2025 at 1:03 PM Gary Gregory < > > > >> > [email protected]> > > > >> > >> > > wrote: > > > >> > >> > > > > > > >> > >> > > > Hi All, > > > >> > >> > > > > > > >> > >> > > > I am cancelling RC1 to address a new ticket that _just_ > > came > > > >> in: > > > >> > >> > > > https://issues.apache.org/jira/browse/LANG-1792 > > > >> > >> > > > > > > >> > >> > > > Thank you, > > > >> > >> > > > Gary > > > >> > >> > > > > > > >> > >> > > > On Tue, Nov 11, 2025 at 7:04 AM Rob Tompkins < > > > >> [email protected]> > > > >> > >> wrote: > > > >> > >> > > > > > > > >> > >> > > > > +0 until I can get my computer! Lets goooooooo! Send it! > > > >> > >> > > > > > > > >> > >> > > > > > On Nov 10, 2025, at 9:24 PM, Gary Gregory < > > > >> > >> [email protected]> > > > >> > >> > > wrote: > > > >> > >> > > > > > > > > >> > >> > > > > > We have fixed a few bugs and added enhancements since > > > >> Apache > > > >> > >> Commons > > > >> > >> > > > > > Lang 3.19.0 was released, so I would like to release > > > Apache > > > >> > >> Commons > > > >> > >> > > > > > Lang 3.20.0. > > > >> > >> > > > > > > > > >> > >> > > > > > Apache Commons Lang 3.20.0 RC1 is available for review > > > >> here: > > > >> > >> > > > > > > > > >> > >> https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1 > > > >> > >> > > > > > (svn revision 80628) > > > >> > >> > > > > > > > > >> > >> > > > > > The Git tag commons-lang-3.20.0-RC1 commit for this RC > > is > > > >> > >> > > > > > eb3b1b4eee9d3ae18e407416a369f32836b6c4b4 which you can > > > >> browse > > > >> > >> here: > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=commit;h=eb3b1b4eee9d3ae18e407416a369f32836b6c4b4 > > > >> > >> > > > > > You may checkout this tag using: > > > >> > >> > > > > > git clone > > > >> > >> https://gitbox.apache.org/repos/asf/commons-lang.git > > > >> > >> > > > > > --branch commons-lang-3.20.0-RC1 > > commons-lang-3.20.0-RC1 > > > >> > >> > > > > > > > > >> > >> > > > > > Maven artifacts are here: > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1877/org/apache/commons/commons-lang3/3.20.0/ > > > >> > >> > > > > > > > > >> > >> > > > > > These are the artifacts and their hashes: > > > >> > >> > > > > > > > > >> > >> > > > > > #Release SHA-512s > > > >> > >> > > > > > #Tue Nov 11 02:08:53 UTC 2025 > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-bin.tar.gz=dfe7b21b0632320353e6ead7deade4e5b9e5cd24e1ebb16461dc9daa2fa134a1099a4e0541445a42ad39431d61bd0d6cc02edb140f646777d0b3bfd8322827df > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-bin.zip=20512dda40dd29296289a154fd33bd204aa5b39f28b20236064fb260325482458162c794490aedd13c27834257ef5ef7fa894bfce78aa7c4b743ca1d917d440c > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-bom.json=5cf3992ecc2164177cc51d54be3e13e55b5d247d0eadaa0a38d17eb80c68e2d5cb88bc14335903c01c507398becd3e63ed977f968c0996d9f29f9119ea1cbb7f > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-bom.xml=0e3ce5ab14f39ee87cf402f8aebdbc4fa335dc71a4f91050a1592a99b1aa7cbd07eb2563003d8e810c0d10d297b2354741c1e7a46c1b54760db48acf20ffa4c2 > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-javadoc.jar=2ad9c102552236d2cf889e044495796ce5b310fcfcb6c82ef3ef7f599270567a58df442ea0199599ccd437d72121768b81d9d50591ec75b9254f74dbf7bc1e99 > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-sources.jar=fc92c5f8614b315103e8a8151492e4002f6a77c88677badd0eee50ab402553dc1e915afd847fc9ba9e95df968296e256b74c0969c0f63818e2e2fd6d8babcb51 > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-src.tar.gz=c120c8731a9f9e144df9a1cb8cc6791ef68e8c8ade33ac6b9227cce4ef762650161628cc784dc61971f980998f75702c9a6cfd5167363c7e06097c759b8cc793 > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-src.zip=1bf89d9622894b92577612d3d89fac264eb8c1fa929d1b106b7ed8361bd78b9e9c641590dfde05ba4578bb96e1283184cdc9827785290ca22790cfa114d49640 > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-test-sources.jar=757486e3f77409e7f7e5af2f1a6854d234707e71bced9945b7589e62ff9fc21ffb71f8245b6110e36fe700126ed27107bd61493ce6aae9727fe51af2edf5653c > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > commons-lang3-3.20.0-tests.jar=a3c6020536ef4f59dd0905e62901091c3efc943ce8048dfd6cba9c5568f947a1de3be3871ba463faca7e3009b994dad483f3b63f0baf9106e4fc7fd290696aaa > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > org.apache.commons_commons-lang3-3.20.0.spdx.json=c884953d5229fc50c0e70e28ecd0c50a8b601e33928a9518a8a35dd3320cbb4d19cfc89aa8bfa56ac0c390899b138158462de385b65b6f02395dc9047acefbaa > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > I have tested this with 'mvn' and 'mvn clean install > > > site' > > > >> > >> using: > > > >> > >> > > > > > > > > >> > >> > > > > > openjdk version "25.0.1" 2025-10-21 > > > >> > >> > > > > > OpenJDK Runtime Environment Homebrew (build 25.0.1) > > > >> > >> > > > > > OpenJDK 64-Bit Server VM Homebrew (build 25.0.1, mixed > > > >> mode, > > > >> > >> sharing) > > > >> > >> > > > > > > > > >> > >> > > > > > Apache Maven 3.9.11 > > > >> (3e54c93a704957b63ee3494413a2b544fd3d825b) > > > >> > >> > > > > > Maven home: /opt/homebrew/Cellar/maven/3.9.11/libexec > > > >> > >> > > > > > Java version: 25.0.1, vendor: Homebrew, runtime: > > > >> > >> > > > > > > > > >> > >> > > > /opt/homebrew/Cellar/openjdk/25.0.1/libexec/openjdk.jdk/Contents/Home > > > >> > >> > > > > > Default locale: en_US, platform encoding: UTF-8 > > > >> > >> > > > > > OS name: "mac os x", version: "15.7.2", arch: > > "aarch64", > > > >> > family: > > > >> > >> > > "mac" > > > >> > >> > > > > > > > > >> > >> > > > > > Darwin Garys-MacBook-Pro.local 24.6.0 Darwin Kernel > > > Version > > > >> > >> 24.6.0: > > > >> > >> > > > > > Wed Oct 15 21:12:15 PDT 2025; > > > >> > >> > > > > > root:xnu-11417.140.69.703.14~1/RELEASE_ARM64_T6041 > > arm64 > > > >> > >> > > > > > > > > >> > >> > > > > > Docker version 28.4.0, build d8eb465 > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > Details of changes since 3.19.0 are in the release > > notes: > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1/RELEASE-NOTES.txt > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1/site/changes.html > > > >> > >> > > > > > > > > >> > >> > > > > > Site: > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1/site/index.html > > > >> > >> > > > > > (note some *relative* links are broken and the > > 3.20.0 > > > >> > >> directories > > > >> > >> > > > > > are not yet created - these will be OK once the site is > > > >> > >> deployed.) > > > >> > >> > > > > > > > > >> > >> > > > > > JApiCmp Report (compared to 3.19.0): > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1/site/japicmp.html > > > >> > >> > > > > > > > > >> > >> > > > > > RAT Report: > > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > > > >> > > > > > https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1/site/rat-report.html > > > >> > >> > > > > > > > > >> > >> > > > > > KEYS: > > > >> > >> > > > > > https://downloads.apache.org/commons/KEYS > > > >> > >> > > > > > > > > >> > >> > > > > > Please review the release candidate and vote. > > > >> > >> > > > > > This vote will close no sooner than 72 hours from now. > > > >> > >> > > > > > > > > >> > >> > > > > > [ ] +1 Release these artifacts > > > >> > >> > > > > > [ ] +0 OK, but... > > > >> > >> > > > > > [ ] -0 OK, but really should fix... > > > >> > >> > > > > > [ ] -1 I oppose this release because... > > > >> > >> > > > > > > > > >> > >> > > > > > Thank you, > > > >> > >> > > > > > > > > >> > >> > > > > > Gary Gregory, > > > >> > >> > > > > > Release Manager (using key 530AA5F25C25011F) > > > >> > >> > > > > > > > > >> > >> > > > > > The following is intended as a helper and refresher for > > > >> > >> reviewers. > > > >> > >> > > > > > > > > >> > >> > > > > > Validating a release candidate > > > >> > >> > > > > > ============================== > > > >> > >> > > > > > > > > >> > >> > > > > > These guidelines are NOT complete. > > > >> > >> > > > > > > > > >> > >> > > > > > Requirements: Git, Java, and Maven. > > > >> > >> > > > > > > > > >> > >> > > > > > You can validate a release from a release candidate > > (RC) > > > >> tag > > > >> > as > > > >> > >> > > follows. > > > >> > >> > > > > > > > > >> > >> > > > > > 1a) Download and decompress the source archive from: > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > >> > > > https://dist.apache.org/repos/dist/dev/commons/lang/3.20.0-RC1/source > > > >> > >> > > > > > > > > >> > >> > > > > > 1b) Check out the RC tag from git (optional) > > > >> > >> > > > > > > > > >> > >> > > > > > This is optional, as a reviewer must check source > > > >> > distributions > > > >> > >> as a > > > >> > >> > > minimum. > > > >> > >> > > > > > > > > >> > >> > > > > > git clone > > > >> > https://gitbox.apache.org/repos/asf/commons-lang.git > > > >> > >> > > > > > --branch commons-lang-3.20.0-RC1 > > commons-lang-3.20.0-RC1 > > > >> > >> > > > > > cd commons-lang-3.20.0-RC1 > > > >> > >> > > > > > > > > >> > >> > > > > > 2) Checking the build > > > >> > >> > > > > > > > > >> > >> > > > > > All components should include a default Maven goal, > > such > > > >> that > > > >> > >> you can > > > >> > >> > > > > > run 'mvn' from the command line by itself. > > > >> > >> > > > > > > > > >> > >> > > > > > 2) Check Apache licenses > > > >> > >> > > > > > > > > >> > >> > > > > > This step is not required if the site includes a RAT > > > report > > > >> > page > > > >> > >> > > which > > > >> > >> > > > > > you then must check. > > > >> > >> > > > > > This check should be included in the default Maven > > build, > > > >> but > > > >> > >> you can > > > >> > >> > > > > > check it with: > > > >> > >> > > > > > > > > >> > >> > > > > > mvn apache-rat:check > > > >> > >> > > > > > > > > >> > >> > > > > > 3) Check binary compatibility > > > >> > >> > > > > > > > > >> > >> > > > > > This step is not required if the site includes a > > JApiCmp > > > >> > report > > > >> > >> page > > > >> > >> > > > > > which you then must check. > > > >> > >> > > > > > This check should be included in the default Maven > > build, > > > >> but > > > >> > >> you can > > > >> > >> > > > > > check it with: > > > >> > >> > > > > > > > > >> > >> > > > > > mvn verify -DskipTests -P japicmp japicmp:cmp > > > >> > >> > > > > > > > > >> > >> > > > > > 4) Build the package > > > >> > >> > > > > > > > > >> > >> > > > > > This check should be included in the default Maven > > build, > > > >> but > > > >> > >> you can > > > >> > >> > > > > > check it with: > > > >> > >> > > > > > > > > >> > >> > > > > > mvn -V clean package > > > >> > >> > > > > > > > > >> > >> > > > > > You can record the Maven and Java version produced by > > -V > > > in > > > >> > your > > > >> > >> > > VOTE reply. > > > >> > >> > > > > > To gather OS information from a command line: > > > >> > >> > > > > > Windows: ver > > > >> > >> > > > > > Linux: uname -a > > > >> > >> > > > > > > > > >> > >> > > > > > 4b) Check reproducibility > > > >> > >> > > > > > > > > >> > >> > > > > > To check that a build is reproducible, run: > > > >> > >> > > > > > > > > >> > >> > > > > > mvn clean verify artifact:compare -DskipTests > > > >> > >> > > > > > -Dreference.repo= > > > >> > >> > > https://repository.apache.org/content/repositories/staging/ > > > >> > >> > > > > > '-Dbuildinfo.ignore=*/*.spdx.json' > > > >> > >> > > > > > > > > >> > >> > > > > > Note that this excludes SPDX files from the check. > > > >> > >> > > > > > > > > >> > >> > > > > > 5) Build the site for a single module project > > > >> > >> > > > > > > > > >> > >> > > > > > Note: Some plugins require the components to be > > installed > > > >> > >> instead of > > > >> > >> > > packaged. > > > >> > >> > > > > > > > > >> > >> > > > > > mvn site > > > >> > >> > > > > > Check the site reports in: > > > >> > >> > > > > > - Windows: target\site\index.html > > > >> > >> > > > > > - Linux: target/site/index.html > > > >> > >> > > > > > > > > >> > >> > > > > > -the end- > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > --------------------------------------------------------------------- > > > >> > >> > > > > > To unsubscribe, e-mail: > > > [email protected] > > > >> > >> > > > > > For additional commands, e-mail: > > > >> [email protected] > > > >> > >> > > > > > > > > >> > >> > > > > > > > >> > >> > > > > > > > >> > >> > > > --------------------------------------------------------------------- > > > >> > >> > > > > To unsubscribe, e-mail: > > [email protected] > > > >> > >> > > > > For additional commands, e-mail: > > > [email protected] > > > >> > >> > > > > > > > >> > >> > > > > > >> > >> > > > > > >> > > > --------------------------------------------------------------------- > > > >> > >> > > To unsubscribe, e-mail: [email protected] > > > >> > >> > > For additional commands, e-mail: [email protected] > > > >> > >> > > > > > >> > >> > > > > > >> > >> > > > >> > >> > > > --------------------------------------------------------------------- > > > >> > >> To unsubscribe, e-mail: [email protected] > > > >> > >> For additional commands, e-mail: [email protected] > > > >> > >> > > > >> > >> > > > >> > > > > >> > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
