Hi Phil and all, It looks like this POOL git commit: < commit 32fd7010d9cf9e789cbba8a51c57b58edc46bcd3 Author: Phil Steitz <[email protected]> 2025-11-07 02:28:22 Committer: Phil Steitz <[email protected]> 2025-11-07 02:28:22 Parent: c5d63adfca0d1063cce6a3a53f4be585cf48c4d1 (Fix for JIRA: POOL-425. Make addObject no-op when maxIdle is attained.) Branches: POOL_2_X, origin/POOL_2_X
Ensure that invalidateObject replaces destroyed instance. JIRA: POOL-424 > breaks DBCP git master. To reproduce: git clone https://github.com/apache/commons-pool.git cd commons-pool git checkout 32fd7010d9cf9e789cbba8a51c57b58edc46bcd3 mvn clean install -DskipTests git clone https://github.com/apache/commons-dbcp.git cd commons-dbcp mvn -Dcommons.pool.version=2.13.0-SNAPSHOT Will fail with: [ERROR] Failures: [ERROR] TestAbandonedBasicDataSource>TestBasicDataSource.testInvalidateConnection:579 expected: <0> but was: <1> [ERROR] TestBasicDataSource.testInvalidateConnection:579 expected: <0> but was: <1> [ERROR] TestPStmtPoolingBasicDataSource>TestBasicDataSource.testInvalidateConnection:579 expected: <0> but was: <1> [ERROR] TestPoolingDriver.testInvalidateConnection:145 expected: <0> but was: <1> [ERROR] TestCPDSConnectionFactory.testConnectionErrorCleanup:82 expected: <0> but was: <1> [ERROR] TestBasicManagedDataSource>TestBasicDataSource.testInvalidateConnection:579 expected: <0> but was: <1> [ERROR] TestDataSourceXAConnectionFactory>TestBasicDataSource.testInvalidateConnection:579 expected: <0> but was: <1> [ERROR] Errors: [ERROR] TestPerUserPoolDataSource.testChangePassword:105 ยป SQL Error invalidating connection [INFO] [ERROR] Tests run: 1605, Failures: 7, Errors: 1, Skipped: 9 You can also build and test with the latest from POOL's git master branch, but it's with commit 32fd7010d9cf9e789cbba8a51c57b58edc46bcd3 that it starts failing for DBCP. I'm not sure if this is a "normal" behavior change that DBCP should apapt to or a bug. Phil? Some context: My plan is to release POOL 2, followed by DBCP, and then work on POOL3/DBCP3 and https://github.com/apache/commons-dbcp/pull/492 Thank you! Gary --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
