Can I have another PMC review please? After the failure of revapi:check the conclusion is that the revapi plugin requires the jar files from other Commons RNG modules to be installed or the build executed with the package goal. This ensures the client-api package is available when the core package runs the API check.
Thanks, Alex On Sun, 19 Apr 2026 at 14:13, Gilles Sadowski <[email protected]> wrote: > > Hi. > > > > > > > > > > > mvn revapi:check > > > > > > > > > > Gary > > > > > > > > > > > > > Thanks. Does the same machine/platform work on git master? > > > > > > On the latest "master", I've run > > > $ mvn > > > $ mvn clean package site site:stage -Pexamples > > > $ mvn revapi:check > > > > > > The first two completed successfully. > > > The last one resulted in the same errors as reported by Gary. > > > > > > Gilles > > > > > > > > On the fresh build environment I created on a linux platform I get the same > > stack of errors when running 'mvn revapi:check' after the successful build. > > The errors are due to lack of access to the client-api jar as it cannot > > find any of those interfaces. Without a goal that attaches the client-api > > jar to the build (e.g. package) then revapi:check fails in a module that > > depends on it. > > > > On the same platform I tried to pre-install the packages and it works OK, > > e.g.: > > > > $ mvn install > > $ mvn revapi:check > > > > Note that we document the usage of the japicmp plugin as requiring the > > package goal (or equivalent). The release validation guide notes state: > > mvn verify -DskipTests -P japicmp japicmp:cmp > > > > So equivalently we require the package goal or the package to be > > pre-installed for the revapi plugin to work in a multi-module build. This > > makes sense since revapi needs to have all the binaries available. > > > > On my MacOS platforms it works because at some point I used the install > > goal. When the package is purged I get the same error: > > > > $ mvn dependency:purge-local-repository > > -DmanualInclude="org.apache.commons:commons-rng-client-api" > > $ mvn revapi:check # fails in commons-rng-core component > > Thanks for checking that "not all goals are equal". > In fact that's something we've stumbled upon for a long time with > modules, when after a "FAIL" build, maven suggests to restart from > where it left off; it doesn't work either if there was no "install" goal. > > Gilles > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
