Hi Henri,

On Sun, Nov 8, 2026 at 9:33 AM Henri Biestro via dev
<[email protected]> wrote:
>
>
> [+1]
>
> - SHA-512 checksums OK for all dist archives and match the vote email.
> - GPG signatures OK (key 530AA5F25C25011F, in KEYS) for dist archives
>   and all Nexus staging artifacts (orgapachecommons-1972).
> - Source archive matches tag commons-bcel-6.14.0-RC1 (bab20a1b).
> - Nexus jars are identical to the jars in the binary archives.
> - LICENSE/NOTICE OK; RAT clean (0 unapproved); no bundled third-party code.
> - japicmp vs 6.13.0: no binary incompatibilities.
> - Default 'mvn' build from the source archive passes (tests, RAT,
>   japicmp, checkstyle, PMD, SpotBugs, javadoc) on:
>     Java 1.8.0_345, 17.0.20, 21.0.8, 25.0.5.0.3, 27.0.1.0.3 (Azul Zulu),
>     Maven 3.9.16, Darwin 27.0.0 arm64
> - 'mvn clean verify site' OK on Java 27; reports clean (Checkstyle 0,
>   SpotBugs 0, RAT 0 unapproved, japicmp OK, 3344 tests 0 failures).
> - Reproducible: built with JDK 27 (TZ=UTC), all jars and the pom on
>   Nexus rebuild byte-for-byte.
> - Smoke-tested the staged jar (Verifier, BCELifier) on Java 8, 17, 21,
>   25 and 27.
>
> Notes:
> - On Java 25+, the Verifier falsely rejects
>   java.lang.String.copyToSegmentRaw(MemorySegment, ...): Pass3aVerifier
>   requires CONSTANT_Methodref for invokestatic, but JVMS 4.9.1 allows
>   CONSTANT_InterfaceMethodref for class files >= 52 (static interface
>   method call). Same in 6.13.0, so not a regression.

Hi Henri,

Thank you for the detailed review.

Worth fixing for the next go around if I can get a better description
of the issue.

> - SBOM: the staged CycloneDX SBOMs record commons-lang3 3.21.0 with
>   SHA-1 a303b7800fe4709f422ce364c4a246bd6d6e338b, but the jar on Maven
>   Central / repository.apache.org is 7bad013a5acee0a078d75fc352a906baa57acb74.
>   It looks like the RC was built against a locally built commons-lang3
>   3.21.0 rather than the published one. BCEL doesn't bundle lang3, so the
>   BCEL bytes are unaffected, but the SBOM is inaccurate. Gary, can you
>   check your local repo?

I built the RC for lang3 locally which explains what you saw. I think
the safest thing to do in the future is, before a release candidate:
rm -rf ~/.m2/repository
which is a good thing to do anyway. I do this once in a while, so I
don't mind doing it more often.

> - Minor: the SHA-512 list in the vote email omits bcel-6.14.0.jar and
>   bcel-6.14.0.pom.

Good find. I fixed this in
https://github.com/apache/commons-release-plugin/commit/10449165df30415458850f4cbd8deb9c91309b5f
and it's available in 1.10.0-SNAPSHOT builds. I'll create an RC later
today.

Gary


>
> Henri
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to