[
https://issues.apache.org/jira/browse/COMMONSRDF-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492075#comment-14492075
]
Stian Soiland-Reyes (old) commented on COMMONSRDF-11:
-----------------------------------------------------
Peter, as a committer that raised the issue, I will prefer to be the one to
decide to close it. You had me convinced about this matter, but I feel it is
patronizing for someone else to close this issue before I have indicated my
support for its rejection.
> Simple should be extendable classes
> -----------------------------------
>
> Key: COMMONSRDF-11
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-11
> Project: Apache Commons RDF
> Issue Type: Improvement
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
>
> In my view, org.apache.commons.rdf.simple should also be a possible basis for
> other implementations - for instance if they only need a new Graph and Triple
> implementation, they should be able to use the other classes directly.
> Current the simple classes are defined like:
> {code}
> final class LiteralImpl implements Literal {
> {code}
> with a mixture of public and package constructors.
> I would prefer for these to all be public, non-final, so that it would be
> easy to extend the simple* classes if so desired, and to instantiate them
> directly without having to make a shadow of SimpleRDFTermFactory.
> (Note - SimpleRDFTermFactory is not final and so can easily be subclassed to
> reuse some of the implementations, but constructors must be at least
> protected to be subclassable outside this package)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
