Github user ansell commented on a diff in the pull request:

    https://github.com/apache/incubator-commonsrdf/pull/10#discussion_r29307257
  
    --- Diff: api/src/main/java/org/apache/commons/rdf/api/BlankNode.java ---
    @@ -41,60 +41,51 @@
      * on the concrete syntax or implementation. The syntactic restrictions on 
blank
      * node identifiers, if any, therefore also depend on the concrete RDF 
syntax or
      * implementation.
    - * 
    + *
      * Implementations that handle blank node identifiers in concrete syntaxes 
need
      * to be careful not to create the same blank node from multiple 
occurrences of
      * the same blank node identifier except in situations where this is 
supported
      * by the syntax. </blockquote>
    - * 
    - * A BlankNode object created through the
    - * {@link RDFTermFactory#createBlankNode()} method must be universally 
unique,
    - * and SHOULD contain a {@link UUID} as part of its
    - * {@link #internalIdentifier()}.
    - * 
    - * A BlankNode object created through the
    - * {@link RDFTermFactory#createBlankNode(String)} method must be 
universally
    - * unique, but also produce the same {@link #internalIdentifier()} as any
    - * previous or future calls to that method on that factory with the same
    - * parameters. In addition, it SHOULD contain a {@link UUID} as part of its
    - * {@link #internalIdentifier()}, created using
    - * {@link UUID#nameUUIDFromBytes(byte[])} using a constant salt for each
    - * instance of {@link RDFTermFactory}, with the given identifier joined to 
that
    - * salt in a consistent manner.
    - * 
      *
    + * A BlankNode SHOULD contain a {@link UUID} string as part of its
    --- End diff --
    
    UUID isn't a string format. Could say "UUID-derived" to get around that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to