OK, now let's go through the concrete issues Andy pointed. On Wed, May 6, 2015 at 7:41 PM, Andy Seaborne <[email protected]> wrote: >> >> ** check LICENSE and NOTICE >> NOTICE missing. >> No LICENSE and NOTICE in artifacts. >> >> >> http://www.apache.org/dev/release.html#notice-required >> >> At a minimum, NOTICE should be: >> http://apache.org/legal/src-headers.html#notice >> >> ------------------------- >> Apache Commons RDF >> Copyright 2015 The Apache Software Foundation >> >> This product includes software developed at >> The Apache Software Foundation (http://www.apache.org/). >> ------------------------- >> >> I've put the files into git but please check: >> >> new file: NOTICE >> new file: api/src/main/resources/META-INF/LICENSE >> new file: api/src/main/resources/META-INF/NOTICE >> new file: simple/src/main/resources/META-INF/LICENSE >> new file: simple/src/main/resources/META-INF/NOTICE >> > Perfect, thanks.
> Dependencies: >> >> The testing dependency JUnit is EPL 1.0: >> >> Do we want a DEPENDENCIES file? >> > Does heart, and in our case it's easy to manage. > ** Unpack and build from 'src' >> OK >> >> The directory name is >> commons-rdf-parent-0.1.0-incubating/ >> not >> apache-commons-rdf-parent-0.1.0-incubating >> >> Does this matter? >> > Not really, bu I do not like it. It comes from the maven-assembly-plugin from either commons-parent or apache-parent. I need to figure out how to solve it. "mvn clean verify" from the 'src' file works with a warning: >> >> -- Build comment 1: >> >> [INFO] --- buildnumber-maven-plugin:1.3:create (default) @ >> commons-rdf-parent --- >> [INFO] Executing: /bin/sh -c cd >> /home/afs/Desktop/R/commons-rdf-parent-0.1.0-incubating && git rev-parse >> --verify HEAD >> [INFO] Working directory: /home/afs/Desktop/R/commonshttps:// >> git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git-rdf-parent-0.1.0-incubating >> [INFO] Storing buildNumber: ?????? at timestamp: 1430927945111 >> [WARNING] Cannot get the branch information from the git repository: >> Detecting the current branch failed: fatal: Not a git repository (or any >> parent up to mount point /home) >> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). >> >> which is true - but what's git got to do with building from source? >> > Probably from the pom.xml... I'll take a look. > -- Build comment 2: >> >> The 'src' file contains 'pom.xml.releaseBackup' and 'release.properties'. >> >> Is that normal for Commons? >> > My error. Those files are generated by the maven-release-plugin to manage the release cycle. I'll try to short it out in the assembly to avoid the inclusion of such 'garbage'. > ** SCM >> >> git clone'd and built but the VOTE email does not have the commit id, >> just a reference to a git tag. >> >> Git tags can be moved. The commit is >> eba760d0b0eeb0f7e9238ff22da78895eb271f43 >> >> We should include the commit id in the VOTE calls. >> > Absolutely. I forgot it, sorry. > The clone URL is >> >> https://git-wip-us.apache.org/repos/asf/incubator-commonsrdf.git >> >> not as in the message: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git > > Yes, again, my mistake. ** Other >> >> The PNG is in the api jar file. Is that intentional? > > I think I'll try to remove all those asset used in the web site from the binary artifacts. Later I'll resume this and try a new rc. Thanks for all the comments. Cheers, -- Sergio Fernández Partner Technology Manager Redlink GmbH m: +43 6602747925 e: [email protected] w: http://redlink.co
