I committed fixed LICENSE (s) retrieved from https://www.apache.org/licenses/LICENSE-2.0.txt which changed some other formatting -- which I don't think is a legal issue or blocker for this release.
https://github.com/apache/incubator-commonsrdf/commit/90b85287a67d3b64ecc83469de5dbbd1fdf7dce2 Inclusion of src/site/resources/css indicates you didn't create the release from a fresh git check-out, which I would strongly recommend for the future. Starting with an empty ~/.m2/repository is also good practice. Thanks for preparing the release candidate! On 7 May 2015 at 17:49, Stian Soiland-Reyes <[email protected]> wrote: > +1 (PPMC binding, IPMC non-binding) > > > * Verified signatures from KEYS > * Verified sha1/md5 (perhaps these should also be included in email?) > fd70a39de363c669744393c57b2fb8f90b15d3c1 > d245c016612632964b070829aa5079c9ed8d2e9b > * zip and tar.gz content match 100% > * zip/tar.gz content matches git tag > 454ebc1ff457bcdb34f4671565bc984e6fbbcb77 - except: > + examples/ missing from archive -- OK for now - but why not include it? > + empty folder src/site/resources/css in zip -- not quite OK, but > I'll let it pass as it is empty > * builds with mvn clean install > * mvn apache-rat:check passes > * No binaries (except png and xcf) > * Includes NOTICE and LICENSE -- however the first line of LICENSE > looks a bit odd as some whitespace seems removed. Fix for next > version. > * META-INF/NOTICE and META-INF/LICENSE correctly included in *.jar artifacts > * Dependencies have acceptable licenses, and do not need to be listed > in NOTICE. Checked with mvn license:aggregate-add-third-party (see > below) > > > I've thrown in a bit of extra checks for good measures :) > > * Runs with the modified examples/pom.xml (had to be checked out from git) > * Staged repository works with the examples/ with a blank .m2/repository/ > * Filenames of api and simple *.jar from Maven staging repositories > matches what gets compiled in */target (I didn't compare beyond > filenames) > > > > > Licenses: > > Lists of 3 third-party dependencies. > (Eclipse Public License 1.0) JUnit (junit:junit:4.12 - http://junit.org) > (The Apache Software License, Version 2.0) Commons RDF: API > (org.apache.commons:commons-rdf-api:0.1.0-incubating - > http://commonsrdf.incubator.apache.org/commons-rdf-api) > (New BSD License) Hamcrest Core (org.hamcrest:hamcrest-core:1.3 - > https://github.com/hamcrest/JavaHamcrest/hamcrest-core) > > > > build tested on On Ubuntu 15.04 x64 with: > > stain@biggie-utopic:/tmp/92/dist.apache.org/repos/dist/dev/incubator/commonsrdf/0.1.0-incubating/1/apache-commons-rdf-0.1.0-incubating$ > mvn -v > Picked up JAVA_TOOL_OPTIONS: -javaagent:/usr/share/java/jayatanaag.jar > Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c; > 2015-03-13T20:10:27+00:00) > Maven home: /home/stain/software/maven > Java version: 1.8.0_45-internal, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "3.19.0-15-generic", arch: "amd64", family: "unix" > > > > > > > Here's another strange thing that is probably also called by settings > in the parent pom: > > > > > stain@biggie-utopic:/tmp/92/dist.apache.org/repos/dist/dev/incubator/commonsrdf/0.1.0-incubating/2/apache-commons-rdf-0.1.0-incubating/simple$ > ls -al target/*jar > -rw-rw-r-- 1 stain stain 18873 May 7 17:37 target/apache-commons-rdf.jar > -rw-rw-r-- 1 stain stain 35337 May 7 17:37 > target/apache-commons-rdf-javadoc.jar > -rw-rw-r-- 1 stain stain 17618 May 7 17:37 > target/apache-commons-rdf-sources.jar > -rw-rw-r-- 1 stain stain 8438 May 7 17:37 > target/apache-commons-rdf-test-sources.jar > > They should be called > commons-rdf-simple-0.1.0-incubating.jar > and not > apache-commons-rdf.jar > > -- but somehow now every module produces the same filename in their > corresponding target/ -- I don't think this breaks anything (they are > luckily still mvn installed with correct names) -- just a bit weird > and confusing for non-Maven folks who might want to pick up the > compiled *.jar from target/ > > No blocker for this release, but definitely something to sort out. > > > > Have a nice weekend! > > > On 7 May 2015 at 15:27, Sergio Fernández <[email protected]> wrote: >> Hello >> >> I am pleased to be calling this vote for the source release of Apache >> Commons RDF 0.1.0-incubating, composed by: >> >> * commons-rdf-api 0.1.0-incubating >> * commons-rdf-simple 0.1.0-incubating >> >> A candidate for the Commons RDF 0.1.0-incubating release is available at: >> >> https://dist.apache.org/repos/dist/dev/incubator/commonsrdf/0.1.0-incubating/ >> >> The release candidate is based on the sources from commit >> 454ebc1ff457bcdb34f4671565bc984e6fbbcb77, tagged as 0.1.0-incubating, at: >> >> https://git-wip-us.apache.org/repos/asf/incubator-commonsrdf.git >> >> Release artifacts are signed with the keys available at: >> >> https://dist.apache.org/repos/dist/release/incubator/commonsrdf/KEYS >> >> A staged Maven repository is available for review at: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1095 >> >> The changelog for this version is available from JIRA: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316620&version=12332056 >> >> Please vote on releasing this package as Apache Commons RDF >> 0.1.0-incubating. The vote is open for at least 72 hours and passes if a >> majority of at least three +1 IPMC votes are cast. >> >> [ ] +1 Release this package >> [ ] 0 I don't feel strongly about it, but I'm okay with the release >> [ ] -1 Do not release this package because... >> >> >> -- >> Sergio Fernández >> Partner Technology Manager >> Redlink GmbH >> m: +43 6602747925 >> e: [email protected] >> w: http://redlink.co > > > > -- > Stian Soiland-Reyes > Apache Taverna (incubating), Apache Commons RDF (incubating) > http://orcid.org/0000-0001-9842-9718 -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons RDF (incubating) http://orcid.org/0000-0001-9842-9718
