[
https://issues.apache.org/jira/browse/COMMONSRDF-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539650#comment-14539650
]
ASF GitHub Bot commented on COMMONSRDF-25:
------------------------------------------
GitHub user stain opened a pull request:
https://github.com/apache/incubator-commonsrdf/pull/14
COMMONSRDF-25 Remove mentions of "local scope"
Fixes [COMMONSRDF-25](https://issues.apache.org/jira/browse/COMMONSRDF-25)
by removing all "may check the local scope" texts within the `.equals()`
Only exception is in `BlankNode`, which keeps the text:
> Blank node identifiers are local identifiers that are used in some
concrete RDF
> syntaxes or RDF store implementations. They are always
> <em>locally scoped</em> to the file or RDF store, and are <em>not</em>
> persistent or portable identifiers for blank nodes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stain/incubator-commonsrdf
COMMONSRDF-25-remove-localscope
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-commonsrdf/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 250c4394cc066b75c643d0dd52c46df87d4ce821
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-05-12T10:56:05Z
COMMONSRDF-25 Remove mentions of "local scope"
(except for in BlankNode about parsing)
----
> Remove mentions of "local scope" in .equals()
> ---------------------------------------------
>
> Key: COMMONSRDF-25
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-25
> Project: Apache Commons RDF
> Issue Type: Bug
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Fix For: 0.2
>
>
> Some of the equals() docs still include texts like
> > Implementations MAY check the local scope for Literal comparison.
> > Implementations MUST also override hashCode() so that two equal Literals
> > produce the same hash code.
> > Implementations MUST check the local scope for Triple comparison if either
> > the subject or object is a BlankNode, and MAY check the local scope in
> > other cases.
> These are leftovers from before COMMONSRDF-6 which hardened BlankNode
> equality, and there is no longer any sense of "local scope". Thus all these
> mentions should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
