Hi Stian, we shouldn't go crazy about being "Commons like". The truth is, that there is no commons style among commons components. For a multi module build I would try to stick to for example VFS. But there will always be differences among components. As long as the build can create releasable artifacts, it's good enough as a starting point for moving Commons RDF to the Commons TLP.
Regards, Benedikt Stian Soiland-Reyes <[email protected]> schrieb am Di., 6. Sep. 2016 um 23:40 Uhr: > I figured out why the reports were missing - it was because we were > overriding the <reportPlugins> and its <reports>. > > > > On 5 September 2016 at 19:33, Gary Gregory <[email protected]> wrote: > > On Mon, Sep 5, 2016 at 12:54 PM, Stian Soiland-Reyes <[email protected]> > > wrote: > > > >> On 5 September 2016 at 17:33, Gary Gregory <[email protected]> > wrote: > >> > I've never used finalName, I'm surprised we'd need this. > >> > >> I think it's to trick the assembly plugin to make > >> apache-commonsrdf-0.2.0-incubating.tar instead of > >> commons-rdf-parent-0.2.0-incubating.tar (and equivalent subdirectory > >> inside) > >> > >> > >> But for the 0.2.0 we had the problem that we got both a -source and > >> -src tar.. so we've got too many assembly plugin executions! > >> > >> (I'm looking at https://github.com/apache/commons-codec as example) > >> > >> > >> Is it right that most Commons components have explicit assembly config > >> files bin and src? > > > > > > I think so. Take a look at a recently released component to be sure. > > > > > >> If I go with that then I can get rid of > >> <finalName> - and thus avoid the confusing > >> "apache-commonsrdf-0.3.0-incubating-SNAPSHOT.jar" which appears in > >> both api/target and simple/target > >> > >> > >> BTW - I struggle to enable all the reports as in > >> https://commons.apache.org/proper/commons-codec/project-reports.html > >> > >> but I only get javadoc and test-javadoc. > >> > >> > >> Do you know how I should build it to get the reports? I tried with "mvn > >> site". > >> > > > > I use 'mvn site'. Maybe this POM file is different from the kinds we > > normally use. I would compare with a POM from a recently released > component. > > > > Gary > > > >> > >> > >> > >> >> This seems to be a new problem with maven-jar-plugin 3.0.0 - fighting > >> >> with the assembly plugin or the bundle plugin? > >> > >> It was double-execution of <goal>jar</goal> - fixed. > >> > >> > >> > >> > >> -- > >> Stian Soiland-Reyes > >> http://orcid.org/0000-0001-9842-9718 > >> > > > > > > > > -- > > E-Mail: [email protected] | [email protected] > > Java Persistence with Hibernate, Second Edition > > <http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > > -- > Stian Soiland-Reyes > http://orcid.org/0000-0001-9842-9718 >
