Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/incubator-commonsrdf/pull/23#discussion_r81149235
  
    --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/JenaGraph.java ---
    @@ -0,0 +1,45 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.commons.rdf.jena;
    +
    +import org.apache.jena.graph.Graph;
    +import org.apache.jena.rdf.model.Model;
    +
    +/** Access the Jena graph backing this object */
    +public interface JenaGraph extends org.apache.commons.rdf.api.Graph {
    +   
    +   /**
    +    * Return the underlying Jena {@link Graph}.
    +    * <p>
    +    * Changes to the Jena graph are reflected in the Commons RDF graph and 
vice versa.
    +    * 
    +    * @return A Jena {@link Graph}
    +    */
    +   public Graph asJenaGraph();
    +
    +   /**
    +    * Return the underlying Jena {@link Model}.
    --- End diff --
    
    Yes, that seems a bit clearer. It's really the word "underlying" (which 
seems to imply preexisting) that gave me pause. But I'd like to hear from 
other, more experienced Jena committers. I may be emphasizing the separation 
between the SPI and the API too strongly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to