Github user stain commented on the issue:

    https://github.com/apache/incubator-commonsrdf/pull/23
  
    Hmm.. Removing `JenaVariable` means in `fromJenaGeneralized(Node)` I have 
to fail on `node.isVariable()` (which [is in the Jena 
API](https://jena.apache.org/documentation/javadoc/jena/org/apache/jena/graph/Node.html#isVariable--)):
    
    e.g. current suggestion
    
    ```java
    if (node.isVariable()) {
      return new JenaVariableImpl(node);
    }
    ```
    
    will instead become:
    
    ```java
    throw new IllegalArgumentException("Unrecognized node type: " + node);
    ```
    
    @afs  - how generalized should I make the generalized quad? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to