solomax commented on a change in pull request #14:
URL: https://github.com/apache/comdev-site/pull/14#discussion_r489370671



##########
File path: layouts/_default/baseof.html
##########
@@ -42,115 +42,118 @@
 </head>
 
 <body>
-
-    <div class="navbar navbar-inverse navbar-fixed-top">
-      <div class="navbar-inner">
-        <div class="container">
-          <button type="button" class="btn btn-navbar" data-toggle="collapse" 
data-target=".nav-collapse">
-            <span class="icon-bar"></span>
-            <span class="icon-bar"></span>
-            <span class="icon-bar"></span>
-          </button>
-          <!-- <a class="brand" href="#">Apache Community Development 
Project</a> -->
-          <div class="nav-collapse collapse">
-            <ul class="nav">
-              <li><a href="/">Home</a></li>
-              <li class="dropdown">
-                <a href="#" class="dropdown-toggle" 
data-toggle="dropdown">About<b class="caret"></b></a>
-                <ul class="dropdown-menu">
-                  <li><a href="/about/">What We Do</a></li>
-                  <li><a href="/newbiefaq.html">Frequently Asked 
Questions</a></li>
-                  <li><a href="/projectIndependence.html">Apache Project 
Independence</a></li>
-                  <li><a 
href="/apache-way/apache-project-maturity-model.html">Apache Project Maturity 
Model</a></li>
-                  <li><a href="/contactpoints.html">Contact Points Within the 
ASF</a></li>
-                  <li><a href="/comdevboardresolution.html">ComDev Original 
Board Resolution</a></li>
-                  <li><a 
href="https://whimsy.apache.org/board/minutes/Community_Development.html";>ComDev
 Board Reports</a></li>
-                  <li><a href="/links.html">Links to additional 
material</a></li>
-                  <li><a
-                  
href="https://issues.apache.org/jira/projects/COMDEV";>Community
-                  Development JIRA</a></li>
-                </ul>
-              </li>
-              <li class="dropdown">
-                <a href="#" class="dropdown-toggle" data-toggle="dropdown">For 
Contributors <b class="caret"></b></a>
-                <ul class="dropdown-menu">
-                  <li><a href="/newcomers/">Newcomers</a></li>
-                  <li><a href="/gettingStarted/101.html">Getting 
Started</a></li>
-                  <li><a href="/contributors/">Finding Your Way Around The 
Apache Software Foundation</a></li>
-                                 <li><a 
href="https://www.apache.org/dev/";>Technical Developer FAQs</a></li>
-                  <li class="divider"></li>
-                  <li class="nav-header">Google Summer of Code</li>
-                  <li><a href="/gsoc.html">Google Summer Of Code 
Information</a></li>
-                  <li><a href="/mentee-ranking-process.html">Mentee Ranking 
Process</a></li>
-                  <li><a href="/mentoring/experiences.html">Past GSoC 
Experiences</a></li>
-                  <li><a href="/guide-to-being-a-mentor.html">Guide to being a 
Mentor</a></li>
-                  <li><a 
href="/use-the-comdev-issue-tracker-for-gsoc-tasks.html">Using ComDev's JIRA 
for GSoC Ideas</a></li>
-                  <li><a href="/gsoc-admin-tasks.html">Tasks of a GSoC Admin 
at the ASF</a></li>
-
-                </ul>
-              </li>
-              <li class="dropdown">
-                <a href="#" class="dropdown-toggle" data-toggle="dropdown">For 
Committers/PMCs <b class="caret"></b></a>
-                <ul class="dropdown-menu">
-                  <li><a href="/newcommitter.html">Recruiting New 
Committers</a></li>
-                  <li><a href="/committers/">Useful Information for 
Committers</a></li>
-                  <li><a href="/committers/consensusBuilding.html">Consensus 
Building</a></li>
-                  <li><a href="/committers/lazyConsensus.html">Lazy 
Consensus</a></li>                                 
-                  <li><a href="/committers/decisionMaking.html">Decision 
Making</a></li>
-                  <li><a href="/committers/voting.html">Voting</a></li>
-                  <li><a href="/committers/funding-disclaimer.html">Funding 
Campaign Disclaimer</a></li>
-                </ul>
-              </li>
-              <li class="dropdown">
-                <a href="#" class="dropdown-toggle" 
data-toggle="dropdown">Mentoring <b class="caret"></b></a>
-                <ul class="dropdown-menu">
-                  <li><a href="/mentoringprogramme.html">Mentoring 
Program</a></li>
-                  <li><a href="/mentorprogrammeformaleducation.html">Mentoring 
in Formal Education</a></li>
-                  <li><a href="/mentorprogrammeapplication.html">Applying for 
the Mentoring Program</a></li>
-                  <li class="divider"></li>
-                  <li class="nav-header">Additional Resources</li>
-                  <li><a href="/guide-to-being-a-mentor.html">Guide to being a 
Mentor</a></li>
-                  <li><a href="/mentor-request-mail.html">Mentor Request Email 
Example</a></li>
-                  <!-- <li><a href="/localmentors.html">Mentors Near 
You</a></li> -->
-                </ul>
-              </li>
-              <li class="dropdown">
-                <a href="#" class="dropdown-toggle" 
data-toggle="dropdown">Events <b class="caret"></b></a>
-                <ul class="dropdown-menu">
-                                 <li><a 
href="https://apachecon.com/";>ApacheCon - The official event of the ASF</a></li>
-                  <li><a href="/calendars/">Major Apache-related 
Events</a></li>
-                  <li><a 
href="https://www.apache.org/events/meetups.html";>Upcoming Apache-related 
meetups</a></li>
-                  <li><a 
href="https://www.apache.org/foundation/marks/events";>Apache event branding 
policies</a></li>
-                  <li class="divider"></li>
-                  <li class="nav-header">Speakers</li>
-                  <li><a href="/speakers/">Speaker Information</a></li>
-                  <li><a href="/speakers/speakers.html">Finding Speakers / 
Listing Yourself as a Speaker</a></li>
-                  <li><a href="/speakers/slides.html">Apache-related 
Slides</a></li>
-                </ul>
-              </li>
-              <li class="dropdown">
-                <a href="#" class="dropdown-toggle" 
data-toggle="dropdown">Join the Conversation<b class="caret"></b></a>
-                <ul class="dropdown-menu">
-                  <li><a 
href="https://www.facebook.com/ApacheSoftwareFoundation";>Facebook</a></li>
-                  <li><a 
href="https://twitter.com/ApacheCommunity";>Twitter</a></li>
-                  <li><a href="/lists.html">Mailing List</a></li>
-                </ul>
-              </li>
-            </ul>
-          </div><!--/.nav-collapse -->
-        </div>
-      </div>
+    <div class="navbar navbar-expand-lg navbar-dark bg-dark fixed-top">
+      <!-- <a class="navbar-brand" href="#">Apache Community Development 
Project</a> -->
+      <button class="navbar-toggler" type="button" data-toggle="collapse" 
data-target="#mainNavbar" aria-controls="mainNavbar" aria-expanded="false" 
aria-label="Toggle navigation">
+        <span class="navbar-toggler-icon"></span>
+      </button>
+      <div class="collapse navbar-collapse" id="mainNavbar">
+        <ul class="navbar-nav mr-auto">
+          <li class="nav-item"><a class="nav-link" href="#">Home</a></li>

Review comment:
       Fixed, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
For additional commands, e-mail: dev-h...@community.apache.org

Reply via email to