cool!
one question, one nitpick:
On 24/06/2008, at 4:59 AM, [EMAIL PROTECTED] wrote:
+ // Check changes
+ if ( !shouldBuild && !
context.getScmResult().getChanges().isEmpty() )
+ {
+ try
+ {
+ ContinuumBuildExecutor executor =
buildExecutorManager.getBuildExecutor( project.getExecutorId() );
+ shouldBuild =
executor.shouldBuild( context.getScmResult().getChanges(), project,
+
workingDirectoryService.getWorkingDirectory( project ),
+
context.getBuildDefinition() );
+ }
+ catch ( Exception e )
+ {
+ //nothing to do
+ }
+ }
it's not clear to me why the exception can be swallowed?
+ int i = 0;
+ while ( i <= files.size() - 1 )
+ {
+ ChangeFile file = files.get( i );
+ boolean found = false;
+ for ( String module : modules )
+ {
+ if ( file.getName().indexOf( module ) > 0 )
+ {
+ files.remove( file );
+ found = true;
+ break;
+ }
+ }
+ if ( !found )
+ {
+ i++;
+ }
+ else
+ {
+ break;
+ }
+ }
can't the i stuff be a standard for loop?
Cheers,
Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
