On Tue, Jun 24, 2008 at 3:51 PM, Brett Porter <[EMAIL PROTECTED]> wrote:
>
> On 24/06/2008, at 5:25 PM, Emmanuel Venisse wrote:
>
>
>>
>>
>>>
>>> + int i = 0;
>>>> + while ( i <= files.size() - 1 )
>>>> + {
>>>> + ChangeFile file = files.get( i );
>>>> + boolean found = false;
>>>> + for ( String module : modules )
>>>> + {
>>>> + if ( file.getName().indexOf( module ) > 0 )
>>>> + {
>>>> + files.remove( file );
>>>> + found = true;
>>>> + break;
>>>> + }
>>>> + }
>>>> + if ( !found )
>>>> + {
>>>> + i++;
>>>> + }
>>>> + else
>>>> + {
>>>> + break;
>>>> + }
>>>> + }
>>>>
>>>>
>>> can't the i stuff be a standard for loop?
>>>
>>
>>
>> What do you mean?
>> I can't use a 'for' loop for the i stuff because in this loop I remove
>> some
>> file in the list.
>>
>
> I think that's a bug then? It will break from both loops (found = true).
>
> You probably want to use an iterator, and then use i.remove()?
I didn't see a bug in all tests I done, I know I don't have writtten junit
test and it's bad.
I'll look to refactor it with iterator
>
>
> Cheers,
> Brett
>
> --
> Brett Porter
> [EMAIL PROTECTED]
> http://blogs.exist.com/bporter/
>
>
