yup
On Tue, Dec 18, 2012 at 1:00 PM, Andrew Grieve <agri...@chromium.org> wrote: > LGTM > > > On Tue, Dec 18, 2012 at 12:16 PM, Simon MacDonald <simon.macdon...@gmail.com >> wrote: > >> Anything I'm missing here before I post it? >> >> >> *1. InAppBrowser – includes events* >> >> >> More details here< >> http://shazronatadobe.wordpress.com/2012/11/21/inappbrowser-based-on-childbrowser-in-cordova-2-3-0/ >> >. >> In a nutshell, this has the same functionality as the >> ChildBrowser<https://github.com/alunny/ChildBrowser>, >> and has events support as well. It supports this simplified spec. Also, the >> InAppBrowser does not use the app whitelist. Example usage: >> >> *2. Device API changes* >> >> >> Minor changes as specified here. For Android, device.name is now >> deprecated >> for all platforms. For all platforms, there is a new property called >> device.model which returns what device.name used to return. >> >> >> *3. Various Bug Fixes* >> >> - Searching for emails in Contacts throws an exception always errors out >> - Create script improvement: Display usage and exit when no arguments >> given >> - Fixed adding a Photo from a HTTPS address to Contact >> - Fixed NPE in onReceivedError with non local errorUrl >> - Camera.getPicture gives error when get a picture from photo library >> with spaces in its name on Android is now fixed >> - Online/Offline events now fire on subsequent pages of an app >> - fixing cordova commands for paths with spaces in them >> - FileEntry.moveTo across file systems incorrectly calls the success >> callback >> >> >> Simon Mac Donald >> http://hi.im/simonmacdonald >>
