man, sure is nice having continuous integration. which is to say: thank you fil
On Mon, Jan 21, 2013 at 4:14 PM, Filip Maj <[email protected]> wrote: > BTW: the last commit on Android bumped the latest results on the ci > dashboard from ~84% to 97%. Thank you everyone for resolving this promptly! > > On 1/21/13 1:48 PM, "Joe Bowser" <[email protected]> wrote: > >>Cool. I re-tagged the JS and Android to include the fix for Android >>2.3.0, since it's early enough. >> >>On Mon, Jan 21, 2013 at 1:19 PM, Andrew Grieve <[email protected]> >>wrote: >>> Yikes, I somehow missed that we're trying to do a 2.4 release. I see now >>> that there were bugs created for it, but was there any kind of "hey, >>>let's >>> do a release"-type email? I thought we'd at least figure out this >>>master vs >>> dev/Next/Stable branch thing before we cut a 2.4. >>> >>> I think the JS fix should be pretty trivial & easier than rolling back >>> since I think we'd need to roll back the related changes on the android >>> code-base as well. >>> >>> >>> On Mon, Jan 21, 2013 at 3:15 PM, Filip Maj <[email protected]> wrote: >>> >>>> According to the CI this isn't working properly on Android 4.x either. >>>> >>>> I think part of this is the array check in the android exec: >>>> >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=f >>>>ram >>>> >>>>ework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e1 >>>>51d<https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob >>>>;f=framework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc >>>>8c632e151d> >>>> cb;hb=dbfe12a9933632700fc5e220777bc617c2356670#l1055 >>>> >>>> >>>> If args[i] is null or undefined, then it will error out. That¹s why >>>>some >>>> of the APIs which are unrelated to the array buffer work are failing. >>>>See >>>> ci.cordova.io for details. >>>> >>>> Another issue is >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=f >>>>ram >>>> >>>>ework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e1 >>>>51d<https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob >>>>;f=framework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc >>>>8c632e151d> >>>> cb;hb=dbfe12a9933632700fc5e220777bc617c2356670#l1056 >>>> >>>> `window.btoa` is probably not available/undefined on the older >>>>androids. >>>> >>>> My vote would be to rollback the array buffer work, and land it in >>>> cordova-js + the underlying platforms only once we have full support >>>>for >>>> android, iOS, blackberry and windows phone. >>>> >>>> On 1/21/13 11:56 AM, "Joe Bowser" <[email protected]> wrote: >>>> >>>> >Hey >>>> > >>>> >We're going through the motions for release, and it seems that the we >>>> >may have to roll back the recent changes to the JS so that we can tag >>>> >for a release. It seems that there were issues with the ArrayBuffer >>>> >changes on Android (and likely others) and the most recent work is >>>> >displaying alert errors when I start it up in Mobile-Spec. >>>> > >>>> >Should we rollback and re-tag the JS (and Android)? Or should we have >>>> >an RC2 ASAP, because this candidate clearly has failed. >>>> > >>>> >Joe >>>> >>>> >
