I don't see any techincal problems with the doc -- the commands all look good to me. Just a couple of comments about the flow:
The very start of the doc talks about working on a feature branch, with no mention on how that is created. Unless that's considered trivial, and everyone is already very comfortable with branching, then I would add a note about starting a feature branch off of master (just a 'checkout master / pull origin master / checkout -b myfeature', really.) The example that you give for using 'squash' is a situation where I would always recommend 'fixup' instead: one large commit with the correct commit message, followed by a sequence of small changes to it. (Although I almost never use squash, so maybe it's just me) Also, should there eventually be a guide for the release managers on tagging and branching? Ian On Mon, Mar 11, 2013 at 7:35 PM, Braden Shepherdson <bra...@chromium.org>wrote: > I wrote up the new git workflows into a doc intended for inclusion in the > Cordova Documentation (it provides much nicer formatting than the wiki). > You can check it out here: > > > https://googledrive.com/host/0B8sLcyOAEX-XUHAxNXhISE5rTTg/guide_contributing_index.md.html > > Please let me know if you spot any problems or have any questions. If > people like the idea of a contributor entry in the Guide, I'll commit this > into edge. > > Braden >
