Sounds good to me, though the prompting with a timeout seems a little weird. If there is multiple I think it would be better just to prompt and wait for a response....
On Fri, Mar 22, 2013 at 3:03 PM, Brian LeRoux <b...@brian.io> wrote: > YES. Do it. > > On Fri, Mar 22, 2013 at 2:38 PM, Filip Maj <f...@adobe.com> wrote: > > Hai gaiz! > > > > Main contention between the two "camps" in this debate is four vs eight > > scripts.. But Brian points out that refactoring smaller bits of > > functionality into their own script allows us to "have our cake and eat > it > > too". This, in turn, results in four + (a subset of the 8) = 10 scripts > in > > total.. Which is an argument for just starting with smaller more discrete > > scripts to begin with, lol. > > > > How about this as a middle ground: > > > > - under /cordova/ we have the four scripts Anis/Andrew recommend: clean, > > log, build and run. These call into various scripts under cordova/lib, > > such as.. > > - under /cordova/lib we have the ~6 scripts I recommended: build-debug, > > build-release, start-emulator, deploy-device, deploy-emulator, and > > possibly a list-devices one as well. > > > > The final point is nailing what `run` does, step-by-step. Paraphrasing > > Anis: > > > > If device(s) connected: > > * Pick device (ignore emulators). > > * Prompt, timeout and pick first one (5 to 10 seconds) if multiple > devices > > are connected (ignore emulators). > > > > If device(s) not connected: > > * Emulator if it is running > > * Prompt, timeout and pick first one (5 to 10 seconds) if multiple > > emulators are running. > > * Start emulator. If you have multiple ones set up (Android's case), > > prompt, timeout and launch first one (5 to 10 seconds). > > > > Yes/no/discuss. Let's try to get to a consensus :) > > > > > > On 3/21/13 5:29 PM, "Brian LeRoux" <b...@brian.io> wrote: > > > >>I knew you'd bring that up! We'll talk more tmrw. > >> > >>On Thu, Mar 21, 2013 at 4:40 PM, Anis KADRI <anis.ka...@gmail.com> > wrote: > >>> Šor you can have functions do discrete actions like so: > >>> > >>> > >>> > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=bi > > >>>n/templates/cordova/cordova;h=1945a4c45f835a6eab3836c4154e518b902d88c6;hb > >>>=HEAD > >>> > >>> Šinstead of creating more inodes. > >>> > >>> > >>> On Thu, Mar 21, 2013 at 4:30 PM, Brian LeRoux <b...@brian.io> wrote: > >>> > >>>> > You could make more scripts as helper scripts, but I still think > >>>>that it > >>>> > will be confusing if a user types "ls" and sees a large number of > >>>> scripts, > >>>> > having to guess what each of them does. > >>>> > >>>> Put them in a subdir called ./lib and be done w/ it. > >>>> > >>>> > >>>> > I don't think having more scripts will make it more likely that the > >>>> scripts > >>>> > will be consistent across platforms. > >>>> > >>>> Ah, but having smaller responsibilities for a module of code makes it > >>>> more testable in discreet form making it easier to confirm said > >>>> suspicions. > >>>> > > >
