The deeper implication is that there are numerous other items that have the same issue, and this is probably best handled with a repo reorg. ( which I am planning to do when I have time, but it still requires some research ) The contents of the www folder are duplicated in both templates as well, including html/js/css that is exactly the same. The VERSION file is repeated ...
The reason for the current structure is that it is very transparent as to how things are used. If we attempt to remove this redundancy we will need to have a way to 'unpack' templates as the user will not be able to just open the template project in VS and select export template. Benn has already done some of this work, however the documentation still explains the other way of opening/exporting a template. Additionally, the code has been this way for a year and a half, without a single issue, so *imho* it is not critical that is fixed before I am back to work in a couple days. @purplecabbage risingj.com On Tue, Mar 26, 2013 at 8:57 AM, Brian LeRoux <b...@brian.io> wrote: > Jesse, while I respect our mutual disdain for the Bruins fan that is Mapes, > it would be more helpful for all of us to know those implications so we can > help while you're out! > > On Tue, Mar 26, 2013 at 8:34 AM, Shirley Adams <shirleya.fu...@gmail.com > >wrote: > > > [?] > > > > > > On Tue, Mar 26, 2013 at 11:29 AM, Jesse MacFadyen < > purplecabb...@gmail.com > > > wrote: > > > >> Benn, > >> Leave it for now, there are deeper implications to removing it. We can > >> discuss more here once I am back to work. > >> > >> > >> > >> Cheers, > >> Jesse > >> > >> Sent from my iPhone5 > >> > >> On 2013-03-25, at 10:36 PM, Benn Mapes <benn.ma...@gmail.com> wrote: > >> > >> Yah, the difference is that Windows Phone has multiple of these > templates > >> so that's why i wanted to pull the cordova folder it out. > >> > >> Sounds like we're on the same page now so i'll go ahead and do that. > >> > >> > >> On Mon, Mar 25, 2013 at 8:24 PM, Filip Maj <f...@adobe.com> wrote: > >> > >> > Yes sounds good. Most other platforms implement it in this way: > >> > > >> > - Android's create script [1] uses a templates folder [2] that it > makes > >> > copies of on-create, which contains (among other things) the cordova > >> > folder [3]. > >> > - Blackberry does a similar thing [4] > >> > - so does iOS [5] > >> > > >> > [1] > >> https://github.com/apache/cordova-android/blob/master/bin/create#L159 > >> > [2] > https://github.com/apache/cordova-android/tree/master/bin/templates > >> > [3] > >> > > >> > https://github.com/apache/cordova-android/tree/master/bin/templates/cordova > >> > [4] > >> https://github.com/apache/cordova-blackberry/tree/master/bin/templates > >> > [5] https://github.com/apache/cordova-ios/tree/master/bin/templates > >> > > >> > On 3/25/13 5:45 PM, "Benn Mapes" <benn.ma...@gmail.com> wrote: > >> > > >> >> I could be reading your responses wrong but, this does not answer my > >> >> proposal, maybe I wasn't clear enough. > >> >> > >> >> For the windows platform there are multiple templates, there is the > >> full > >> >> template which includes a dll of the cordovaLib(native code) and a > >> >> standalone template which uses the source code. > >> >> > >> >> Right now there cordova folders within each of these containing all > the > >> >> project scripts (when you create a project it will use one of these > >> >> templates - default is full template). My proposal was to pull the > >> cordova > >> >> folder out of the templates and put it in one spot so there isn't any > >> >> duplication of these scripts which will add more consistency. Then > when > >> >> create is called, it will just copy that single cordova folder > >> containing > >> >> all the scripts into the created project folder. > >> >> > >> >> Does that make sense? > >> >> > >> >> > >> >> > >> >> > >> >> On Mon, Mar 25, 2013 at 1:48 PM, Filip Maj <f...@adobe.com> wrote: > >> >> > >> >>> We already have established spots for scripts. > >> >>> > >> >>> Global scripts: > >> >>> > >> >>> cordova-<platform>/bin/create > >> >>> cordova-<platform>/bin/check_reqs (in the works) > >> >>> > >> >>> > >> >>> Project-level scripts: > >> >>> > >> >>> Myapp/cordova > >> >>> Myapp/cordova/lib (soon to come) > >> >>> > >> >>> On 3/25/13 1:38 PM, "Benn Mapes" <benn.ma...@gmail.com> wrote: > >> >>> > >> >>>> Right now most of the scripts for windows phone except create are > in > >> >>>> /tooling/scripts/ > >> >>>> and there are duplicate cordova folders in each template > >> (/templates/*) > >> >>>> folder with the emulate and debug scripts for deploying to > >> >>> emulator/device > >> >>>> respectively. > >> >>>> > >> >>>> In light of the recent scripting discussion I would like to propose > >> >>> moving > >> >>>> all the scripts that will go into the cordova folder of a project > >> into > >> >>>> /framework/cordova/ (or maybe /tooling/cordova/). This folder can > >> then > >> >>> be > >> >>>> copied into a new project when the create command is called. > >> >>>> > >> >>>> That way we only have one place where all these scripts reside, > >> >>> instead of > >> >>>> having a cordova folder for each template. > >> >>>> > >> >>>> Thoughts? > >> > > >> > > >> > > > > >
