Looks like your lacking tests in both the metadata as well as places like platform (https://github.com/bennmapes/cordova-cli/blob/windows2/spec/platform.spec. js) etc
Happy to give your changes a whirl, but are you planning on contributing tests? Particularly in that https://github.com/bennmapes/cordova-cli/blob/windows2/src/metadata/wp8_par ser.js needs to do the fun stuff of updating the proj file , which would easily go screwy. mw On 4/10/13 4:46 PM, "Benn Mapes" <[email protected]> wrote: >I well the pull request is still there and I have 2 branches with the >windows phone support, the old one: > >https://github.com/bennmapes/cordova-cli/tree/windows > >And the updated one with the latest cli changes (2.6.0) > >https://github.com/bennmapes/cordova-cli/tree/windows2 > >The only thing that needs to happen is for people to start using it and >submitting issues. If we're not going to pull out the the platforms in >/lib >and add them dynamically then I see no reason to hold off pulling this in. > > >On Wed, Apr 10, 2013 at 12:08 PM, Michael Wolf ><[email protected]>wrote: > >> Benn: >> >> Looking for any help here ? Really looking for the wp8 cli to come in >>so >> we can drop our own sad little wp8 scripts. >> >> Hit me up directly if your looking for a hand/eye. >> >> mw >> >> On 3/22/13 6:06 PM, "Filip Maj" <[email protected]> wrote: >> >> >Sweet. Don't forget tests :) >> > >> >On 3/22/13 3:02 PM, "Benn Mapes" <[email protected]> wrote: >> > >> >>I have added support for wp7 + wp8 on this branch and made a pull >>request >> >>to cordova-cli but I think it would be best to hold off merging it >> >>in until we decide what to do with the lib folder (i.e dynamically >>load >> >>platforms when we call `cordova platform add foo` for the first time). >> >> >> >>https://github.com/bennmapes/cordova-cli/tree/windows >> >> >> >>Just woking on the update_config function in the wp*_parser so that >>you >> >>can >> >>change the name/id from the config.xml >> >> >> >> >> >>On Fri, Mar 22, 2013 at 10:58 AM, Brian LeRoux <[email protected]> wrote: >> >> >> >>> None have support currently in the CLI tools. >> >>> >> >>> - Herm is pursuing platform level scripts so support for FxOS can >> >>>happen. >> >>> - Mapes is doing the same in Windows land. >> >>> >> >>> Both cases we could use some help. If any on this list care about >> >>> those platforms and would like to pitch in this is the thread to >> >>> introduce yourself. >> >>> >> > >> >>
