I would say this is low risk since it's adding a parameter at the end (so existing usage works) where we can have a default of "" which it is already I think.
On Tue, Apr 23, 2013 at 10:14 AM, Andrew Grieve <agri...@chromium.org>wrote: > Makes sense. > > > On Tue, Apr 23, 2013 at 11:45 AM, James Jong <wjamesj...@gmail.com> wrote: > > > https://issues.apache.org/jira/browse/CB-3022 > > > > Per CB-3022 JIRA request, does anyone have issues with adding an optional > > default text value to the JS for prompt dialog? > > > > Current: > > prompt: function(message, resultCallback, title, buttonLabels) > > > > Proposed change: > > prompt: function(message, resultCallback, title, buttonLabels, > defaultText) > > > > -James Jong >
