Yeah, for things like whitelist and preferences this seems necessary :). Ship it!
On Wed, Apr 24, 2013 at 12:27 PM, Michal Mocny <[email protected]> wrote: > I think "missing target" bugs would be masked if no-target applied to all. > Platform specific changes applied to other platforms may usually be > harmlessly ignored and go unnoticed, but sometimes cause hard. > > Therefore, I would prefer a target="all" or target="common". > > I think its a good idea, though. > > -Michal > > > On Wed, Apr 24, 2013 at 12:17 PM, Filip Maj <[email protected]> wrote: > > > Here's another thought about the config-file changes. > > > > I noticed some of the plugins out there have <access> tags at the top > > level in a plugin's plugin.xml. At first I was like wtf that should exist > > under a <config-file> element, pointing to the config.xml for each > > platform. I realize now the problem with that, though, is that you'll > need > > one of these for each platform, because the target location of the > > config.xml is in different spots, I.e.: > > > > - Android: <config-file target="res/xml/config.xml"><access > > blah></config-file> > > - iOS: <config-file target="www/config.xml"><access blah></config-file> > > > > - BlackBerry: <config-file target="www/config.xml"><access > > blah></config-file> > > > > > > Should we provide some way of modifying the config.xml, agnostic of the > > platform, just for these cases where certain config.xml changes apply to > > all platforms? If so, how? A top-level <config-file> element (perhaps > with > > no target attrib)? > > > > On 4/23/13 7:28 PM, "Anis KADRI" <[email protected]> wrote: > > > > >It doesn't. All configuration edits should happen in prepare > > >(adding/removing xml fragments etc..). > > > > > > > > >On Tue, Apr 23, 2013 at 7:05 PM, Michal Mocny <[email protected]> > > wrote: > > > > > >> +1 move to prepare, however, why does this only apply to access tags? > > >> > > >> > > >> On Tue, Apr 23, 2013 at 7:16 PM, Filip Maj <[email protected]> wrote: > > >> > > >> > that¹s what I was thinking too > > >> > > > >> > On 4/23/13 4:13 PM, "Anis KADRI" <[email protected]> wrote: > > >> > > > >> > >On Tue, Apr 23, 2013 at 4:03 PM, Filip Maj <[email protected]> wrote: > > >> > > > > >> > >> One thing that I intentionally removed from platform-level > > >>`install` > > >> was > > >> > >> adding <access> tags to the config. I figure this should probably > > >>go > > >> > >>into > > >> > >> `prepare`. Thoughts? > > >> > >> > > >> > > > > >> > >In my opinion, this should be part of a configuration handler that > > >> should > > >> > >be called by 'prepare'. > > >> > > > >> > > > >> > > > > >
