Okay—I'll commit the reversion. Jesse will investigate another approach to eliminating document.write; Jesse, let me know if you have something else to try and I'll run it on the offending device.
On Mon, May 27, 2013 at 3:25 PM, Jesse <purplecabb...@gmail.com> wrote: > Yes, there is a restriction against writing scripts with document.write in > Windows8 for Windows Store Apps. > + I think that the proper way via createElement. > If you think it is better to just revert my change, that is fine, but I > think it points to another latent bug that is requiring a specific load > order, and we had/have an unknown race condition issue. > I will also look at alternatives. > > Max, did reverting it fix it? > > > @purplecabbage > risingj.com > > > On Mon, May 27, 2013 at 11:04 AM, Max Woghiren <m...@chromium.org> wrote: > >> I'll take a look at whether reverting this change fixes the issue. If >> so, I'll also wait for Jesse to chime in before doing anything else with it. >> >> >> On Mon, May 27, 2013 at 1:52 PM, Joe Bowser <bows...@gmail.com> wrote: >> >>> I think it was made because document.write is ugly. That being said, >>> does this break something for WP? Seriously, adding a script tag >>> shouldn't cause the browser to not redraw, but I've seen stranger. >>> >>> On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <agri...@chromium.org> >>> wrote: >>> > Might have been this change: >>> > >>> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d >>> > >>> > Maybe let's just revert it? Not sure why it was made in the first >>> place? >>> > >>> > >>> > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bows...@gmail.com> wrote: >>> > >>> >> Hey >>> >> >>> >> While I was setting up my environment on the Chromebook for JSConf, I >>> >> noticed that I ran into the Android 4.0.3 bug again. It seems that >>> >> when I was testing 4.0.3 last, I was using an old mobile-spec. After >>> >> going through the project, it seems that the changes that were made to >>> >> mobile-spec breaks rendering on Android. I have no idea why this >>> >> would be, but this browser bug has nothing to do with the Android >>> >> changes, and is most likely something to do with the Android ICS >>> >> browser being a piece of crap. >>> >> >>> >> At any rate, can we get this fixed so that we can actually test this >>> >> release? What did we do to break mobile-spec on Ice Cream Sandwich? >>> >> Anyone have any ideas? >>> >> >>> >> Joe >>> >> >>> >> >> >
