Sweet, thanks! I think I'll omit pulling this into the 2.8.x branch and stay off until 2.9, let it bake a little. My tests pass, though, so should be good.
On 6/4/13 12:04 PM, "Benn Mapes" <[email protected]> wrote: >Allright, I pushed the changes up to master2 >https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=796ad >93a062d5e963d947f4c740a7c330184b49e > > >On Tue, Jun 4, 2013 at 9:32 AM, Michael Brooks ><[email protected]>wrote: > >> Great work Benn. Braden echoed exactly my thoughts. >> >> >> On Tue, Jun 4, 2013 at 7:47 AM, Braden Shepherdson <[email protected] >> >wrote: >> >> > I've wanted to do this since I first opened the files in CLI. It's >>much >> > better these days than it was, at least. Glad to see it's still >>moving. >> > >> > Braden >> > >> > >> > On Mon, Jun 3, 2013 at 8:42 PM, Filip Maj <[email protected]> wrote: >> > >> > > Works well for me on my machine, +1 >> > > >> > > On 6/3/13 5:40 PM, "Benn Mapes" <[email protected]> wrote: >> > > >> > > >Working with the cordova-cli code I have noticed that there are >>lots >> of >> > > >repetitive platform-specific references in many of the files. I >>have >> > tried >> > > >to consolidate all of these into the platforms.js file at the root >>of >> > the >> > > >project. I push up this branch to apache: >> > > > >> > > >> > >> >>https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=shortlog;h=re >>f >> > > >s/heads/platform-reorg >> > > > >> > > >As far as I know, all the test pass on windows and mac, I haven't >> > > >physically tested every part yet to make sure this didn't break >> anything >> > > >but I believe not. >> > > > >> > > >This change is working towards consolidating all platforms so that >> it's >> > > >very easy to add and remove them if needed. The ultimate goal for >> > adding a >> > > >new platform should be to just add it to platforms.js and create a >> > parser >> > > >+ >> > > >tests for it. >> > > > >> > > >Please let me know what you think, if everyone is in agreeance hen >>I >> > will >> > > >add this to the master2 branch. >> > > > >> > > >~Benn >> > > >> > > >> > >>
