-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12114/
-----------------------------------------------------------
(Updated June 27, 2013, 2:24 a.m.)
Review request for cordova, Joe Bowser and Braden Shepherdson.
Changes
-------
Awesome! I'm away tomorrow, but will check this in on Friday. Thanks guys!
Bugs: CB-3384
https://issues.apache.org/jira/browse/CB-3384
Repository: cordova-android-git
Description
-------
[CB-3384] Rewrite of DataResource into UriResolver + UriResolvers
Includes unit tests woot!
Note that this remove CordovaPlugin.shouldInterceptRequest(). Should be
fine since this method was introduced only a couple of releases ago, was
never documented, and afaict was only used by the Chrome Cordova plugins.
Diffs (updated)
-----
framework/src/org/apache/cordova/CordovaWebView.java
67775a192b35ad1404665285ff1b59efbeb62413
framework/src/org/apache/cordova/FileHelper.java
ebbdc8df941561734a6b115f001bf1a45e328e06
framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java
1e190b66d19a56ab2f6434b63660d717b167afca
framework/src/org/apache/cordova/UriResolver.java PRE-CREATION
framework/src/org/apache/cordova/UriResolvers.java PRE-CREATION
framework/src/org/apache/cordova/api/CordovaPlugin.java
2b225e646345579f7a325441bfbc3238d2e5d2dc
framework/src/org/apache/cordova/api/PluginManager.java
0a42b3abd2fc9c684728dbbdeb0cc62cd335c2b3
test/src/org/apache/cordova/test/UriResolversTest.java PRE-CREATION
test/src/org/apache/cordova/test/actions/CordovaWebViewTestActivity.java
1185bad15fa3dddafa4152912bd5b7f755a5d47c
Diff: https://reviews.apache.org/r/12114/diff/
Testing
-------
Thanks,
Andrew Grieve