I am not saying it's a good idea only for this reason. There could be other
reasons. There are (or will be) cases where a plugin might require some
some sort of build phase or additional steps that are not supported by the
plugman specs out of the box. Besides npm supports it [1] so why not
plugman ?

[1] https://npmjs.org/doc/scripts.html


On Wed, Jul 3, 2013 at 10:42 AM, Michal Mocny <[email protected]> wrote:

> Andrew and I had that conversation as few days ago, and he convinced me
> that shipping code to end users should mean shipping with node_modules
> (this sentiment is repeated from the creators of npm it seems).  That way,
> any given users' node setup/platform version issues don't affect your code.
>  Thus, I don't think npm install as a hook for plugman for install time is
> necessary, not a good idea (at least not for this reason).
>
> -Michal
>
>
> On Wed, Jul 3, 2013 at 10:31 AM, Anis KADRI <[email protected]> wrote:
>
> > You could also ship your plugin as a node package (with a package.json
> and
> > node_modules) and point your js paths to node_modules/ (just as +andrew
> > said). Maybe plugman should also support before_ and after_ hooks as well
> > in order to run "npm install" ?
> >
> >
> > On Wed, Jul 3, 2013 at 9:59 AM, Bryan Bishop <[email protected]> wrote:
> >
> > > On Tue, Jul 2, 2013 at 5:53 PM, Don Coleman <[email protected]>
> > wrote:
> > >
> > > > I ripped a bunch of Javascript code out of my Cordova NFC plugin and
> > > > created a NPM so I could reuse the code elsewhere.
> > > >
> > >
> > > Is this something that runs on a phone? Does this mean you're running
> > your
> > > node module through browserify first?
> > >
> > > - Bryan
> > > http://heybryan.org/
> > > 1 512 203 0507
> > >
> >
>

Reply via email to