> On July 12, 2013, 5:29 p.m., Andrew Grieve wrote: > > coho, line 1204 > > <https://reviews.apache.org/r/12514/diff/1/?file=320871#file320871line1204> > > > > Having a "pretend" mode probably is a nice idea. Maybe add a flag for > > it?
Done > On July 12, 2013, 5:29 p.m., Andrew Grieve wrote: > > coho, line 1205 > > <https://reviews.apache.org/r/12514/diff/1/?file=320871#file320871line1205> > > > > Might be nice to log() a status report here. Should use the print() > > function when doing so. e.g.: > > > > print('Creating issue: ' + issue.name) Done > On July 12, 2013, 5:29 p.m., Andrew Grieve wrote: > > coho, line 1350 > > <https://reviews.apache.org/r/12514/diff/1/?file=320871#file320871line1350> > > > > Insert. Done > On July 12, 2013, 5:29 p.m., Andrew Grieve wrote: > > coho, line 1360 > > <https://reviews.apache.org/r/12514/diff/1/?file=320871#file320871line1360> > > > > nit: use the fatal() helper instead of throwing. I replaced the throw statements with calls to fatal(). > On July 12, 2013, 5:29 p.m., Andrew Grieve wrote: > > coho, line 1393 > > <https://reviews.apache.org/r/12514/diff/1/?file=320871#file320871line1393> > > > > fatal() Done > On July 12, 2013, 5:29 p.m., Andrew Grieve wrote: > > coho, line 1396 > > <https://reviews.apache.org/r/12514/diff/1/?file=320871#file320871line1396> > > > > Remove Done. - Jeffrey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12514/#review23090 ----------------------------------------------------------- On July 12, 2013, 6:47 p.m., Jeffrey Willms wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12514/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 6:47 p.m.) > > > Review request for cordova and Andrew Grieve. > > > Bugs: CB-4134 > https://issues.apache.org/jira/browse/CB-4134 > > > Repository: cordova-coho > > > Description > ------- > > Adding command to coho for creating release bugs. > > > Add .reviewboardrc. > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > coho b89742e0427f5fe15e8f10c00c5f38a8b7da42fa > package.json 747e9c2de7a29752adb1ba44df0f0d70ca72cb1f > > Diff: https://reviews.apache.org/r/12514/diff/ > > > Testing > ------- > > > Thanks, > > Jeffrey Willms > >
