agree
On Thu, Jul 25, 2013 at 12:24 PM, Anis KADRI <[email protected]> wrote: > I didn't know that there was a Cordova group. I am new to this review process. > The meat is here [1]. Now that I think about it, I don't think it > should be a separate module. It should be part of plugman itself. I > can work on adding it, if it makes sense. > > [1] https://github.com/imhotep/plugman-registry > > On Thu, Jul 25, 2013 at 9:04 AM, Andrew Grieve <[email protected]> wrote: >> Yeah, yet another account to create :( >> >> Anis - looked at both reviews, but it seems like the meat is missing. Where >> is the plugman-registry module coming from? >> >> >> On Thu, Jul 25, 2013 at 11:55 AM, Filip Maj <[email protected]> wrote: >> >>> Guess I need to sign up for this review board thing .. >>> >>> On 7/25/13 8:52 AM, "Andrew Grieve" <[email protected]> wrote: >>> >>> >In case anyone else wants to have a look, the review requests are: >>> >https://reviews.apache.org/r/12929/ >>> >https://reviews.apache.org/r/12931/ >>> > >>> >Anis - it'd be good to set the group on these reviews to "cordova", and to >>> >enter in the bug iD. >>> > >>> > >>> >On Wed, Jul 24, 2013 at 9:28 PM, Andrew Grieve <[email protected]> >>> >wrote: >>> > >>> >> Neat! I like this one: >>> >> >>> >> >>> >>"_from":"/Users/anis/Projects/cordova/cordova-coho/cordova-plugin-camera/ >>> >>" >>> >> >>> >> >>> >> So long as we're generating the package.json, we can commandeer fields >>> >>that we know get stored for our own purposes :). E.g. stuff the engine >>> >>info in the _from field. >>> >> >>> >> >>> >> >>> >> On Wed, Jul 24, 2013 at 7:23 PM, Anis KADRI <[email protected]> >>> >>wrote: >>> >> >>> >>> Just `curl >>> >>>http://registry.cordova.io/camera`<http://registry.cordova.io/camera >>> >(or >>> >>> any plugin name) or >>> >>> enter it in your browser to see what's stored. Basically: "not a hell >>> >>> of a lot" xD. >>> >>> >>> >>> I've created a review request for Andrew and Braden, both plugman and >>> >>> cli and if you guys agree I can merge it this week. I was hoping today >>> >>> but it can wait a few more days. >>> >>> >>> >>> On Wed, Jul 24, 2013 at 4:04 PM, Andrew Grieve <[email protected]> >>> >>> wrote: >>> >>> > On Wed, Jul 24, 2013 at 3:47 PM, Anis KADRI <[email protected]> >>> >>> wrote: >>> >>> > >>> >>> >> Just catching up... >>> >>> >> >>> >>> >> To answer various questions: >>> >>> >> >>> >>> >> I am not sure about the Apache VM but irishcouch [1] is graciously >>> >>> >> offering us a free CouchDB instance. What's cool about couch is that >>> >>> >> it's really easy to replicate data across multiple instances. I am >>> >>> >> using a proxy on EC2 to handle URL rewrites and requests but it >>> >>> >> doesn't do anything else. I believe CouchDB can do that itself but I >>> >>> >> haven't looked into it. >>> >>> >> >>> >>> > Awesome, yeah, I pinged Mike's bug, but don't think it's worth >>> >>>delaying >>> >>> if >>> >>> > it doesn't get resolved in time. >>> >>> > >>> >>> > >>> >>> >> >>> >>> >> As far as stats, I haven't looked into it yet but it's definitely an >>> >>> >> important feature. So it is one of the first things I will be >>> >>>looking >>> >>> >> into once I merge everything back into master. >>> >>> >> >>> >>> >> It stores the tarball (tgz) indeed and doesn't store the plugin.xml >>> >>> >> separately unfortunately. We'd have to fork npm in order to do that. >>> >>> >> >>> >>> > I suppose what I was getting at was - how does "npm search" work? >>> >>>what >>> >>> info >>> >>> > is kept in the DB besides the tgz? I think we'd want our <engine> >>> >>>info >>> >>> > before downloading the tgz. >>> >>> > >>> >>> > >>> >>> >> >>> >>> >> The README is indeed not up to date (I should get on that!) but the >>> >>> >> help doc is [2] >>> >>> >> >>> >>> >> As far as naming conventions. According to npm's conventions >>> >>> >> "The name ends up being part of a URL, an argument on the command >>> >>> >> line, and a folder name. Any name with non-url-safe characters will >>> >>>be >>> >>> >> rejected. Also, it can't start with a dot or an underscore." >>> >>> >> >>> >>> >> I am guessing that we could use org.apache.cordova.camera or >>> >>>whatever >>> >>> >> but is that user friendly ? I don't know....It's definitely better >>> >>>to >>> >>> >> have that because it allows developers to create plugins for the >>> >>>same >>> >>> >> functionality without having to name it "camera4156" for example. >>> >>>It's >>> >>> >> up for debate. >>> >>> >> >>> >>> >> [1] http://www.iriscouch.com/ >>> >>> >> [2] >>> >>> >> >>> >>> >>> >>> >>> https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=blob;f=d >>> >>>oc/help.txt;h=ae90cd7568f28d7816abad8cfa1b786cbee956ef;hb=plugman-regist >>> >>>ry >>> >>> >> >>> >>> >> On Wed, Jul 24, 2013 at 10:58 AM, Steven Gill >>> >>><[email protected]> >>> >>> >> wrote: >>> >>> >> > I created this issue [1] for fixing the name tag for the plugins. >>> >>>I >>> >>> think >>> >>> >> > this is what Anis meant. I am creating dev branches for plugins >>> >>> right now >>> >>> >> > and going to make this change + [2] and [3]. >>> >>> >> > >>> >>> >> > [1] https://issues.apache.org/jira/browse/CB-4370 >>> >>> >> > [2] https://issues.apache.org/jira/browse/CB-4338 >>> >>> >> > [3] https://issues.apache.org/jira/browse/CB-4371 >>> >>> >> > >>> >>> >> > >>> >>> >> > On Wed, Jul 24, 2013 at 10:47 AM, Andrew Grieve < >>> >>> [email protected] >>> >>> >> >wrote: >>> >>> >> > >>> >>> >> >> Anis - want to put your changes up on reviews.apache.org? Would >>> >>> make it >>> >>> >> >> easier to see & comment on your changes. >>> >>> >> >> >>> >>> >> >> >>> >>> >> >> On Wed, Jul 24, 2013 at 12:08 PM, Mike Billau < >>> >>> [email protected]> >>> >>> >> >> wrote: >>> >>> >> >> >>> >>> >> >> > (Still no word from ASF on the Apache VM: >>> >>> >> >> > https://issues.apache.org/jira/browse/INFRA-6422) >>> >>> >> >> > >>> >>> >> >> > On Wed, Jul 24, 2013 at 11:50 AM, Braden Shepherdson < >>> >>> >> >> [email protected] >>> >>> >> >> > >wrote: >>> >>> >> >> > >>> >>> >> >> > > Looks good! >>> >>> >> >> > > >>> >>> >> >> > > I'm wondering about the naming convention - does that mean >>> >>>we'll >>> >>> >> have >>> >>> >> >> to >>> >>> >> >> > > change all our plugins from java.style.reverse.domains to >>> >>> >> singlewords? >>> >>> >> >> > > >>> >>> >> >> > > Braden >>> >>> >> >> > > >>> >>> >> >> > > >>> >>> >> >> > > On Tue, Jul 23, 2013 at 6:04 PM, Andrew Grieve < >>> >>> >> [email protected] >>> >>> >> >> > >wrote: >>> >>> >> >> > > >>> >>> >> >> > >> Will definitely try this out tomorrow! Super awesome! >>> >>> >> >> > >> >>> >>> >> >> > >> Where is the database hosted? I remember a while ago Mike >>> >>>was >>> >>> >> going to >>> >>> >> >> > >> look >>> >>> >> >> > >> into getting an Apache VM to host server things on. Did that >>> >>> come >>> >>> >> >> about? >>> >>> >> >> > >> >>> >>> >> >> > >> One of the things we'll hugely benefit from this is getting >>> >>> stats >>> >>> >> on >>> >>> >> >> > what >>> >>> >> >> > >> plugins people are installing. Is that a feature yet? >>> >>> >> >> > >> >>> >>> >> >> > >> Wondering what gets hosted on the server when you "plugman >>> >>> >> publish". >>> >>> >> >> I'm >>> >>> >> >> > >> guessing a .tgz of your plugin... Is that right? Does it >>> >>>store >>> >>> the >>> >>> >> >> > >> plugin.xml separately from the .tgz so that metadata can be >>> >>> queried >>> >>> >> >> from >>> >>> >> >> > >> it? >>> >>> >> >> > >> >>> >>> >> >> > >> >>> >>> >> >> > >> >>> >>> >> >> > >> On Tue, Jul 23, 2013 at 7:50 PM, Anis KADRI < >>> >>> [email protected]> >>> >>> >> >> > wrote: >>> >>> >> >> > >> >>> >>> >> >> > >> > Sure, >>> >>> >> >> > >> > >>> >>> >> >> > >> > cordova-plugman is here [1] >>> >>> >> >> > >> > >>> >>> >> >> > >> > cordova-cli is here [2] >>> >>> >> >> > >> > >>> >>> >> >> > >> > the registry itself is here [3] and the website to browse >>> >>> >> plugins >>> >>> >> >> is >>> >>> >> >> > >> here >>> >>> >> >> > >> > [4] >>> >>> >> >> > >> > >>> >>> >> >> > >> > [1] http://bit.ly/1bKTvsd >>> >>> >> >> > >> > [2] http://bit.ly/1bKTHYu >>> >>> >> >> > >> > [3] http://registry.cordova.io >>> >>> >> >> > >> > [4] http://plugins.cordova.io >>> >>> >> >> > >> > >>> >>> >> >> > >> > It's easy to setup your own registry and it's also easy to >>> >>> >> replicate >>> >>> >> >> > >> from >>> >>> >> >> > >> > one registry to the other. >>> >>> >> >> > >> > >>> >>> >> >> > >> > -a >>> >>> >> >> > >> > >>> >>> >> >> > >> > >>> >>> >> >> > >> > On Tue, Jul 23, 2013 at 4:41 PM, Steven Gill < >>> >>> >> >> [email protected]> >>> >>> >> >> > >> > wrote: >>> >>> >> >> > >> > >>> >>> >> >> > >> > > Hey Anis, >>> >>> >> >> > >> > > >>> >>> >> >> > >> > > Sounds awesome! Can you share the repo links for the >>> >>> registry >>> >>> >> >> itself >>> >>> >> >> > >> and >>> >>> >> >> > >> > > any other repos that are related? >>> >>> >> >> > >> > > >>> >>> >> >> > >> > > >>> >>> >> >> > >> > > On Tue, Jul 23, 2013 at 4:26 PM, Anis KADRI < >>> >>> [email protected]> >>> >>> >> >> > wrote: >>> >>> >> >> > >> > > >>> >>> >> >> > >> > > > Hello, >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > I wanted to update the list on my progress on this >>> >>>topic. >>> >>> >> I've >>> >>> >> >> > been >>> >>> >> >> > >> > > working >>> >>> >> >> > >> > > > on this for the past month or so and I believe it will >>> >>> solve >>> >>> >> the >>> >>> >> >> > >> issue >>> >>> >> >> > >> > of >>> >>> >> >> > >> > > > finding plugins for our users (core and 3rd party). >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > I committed everything to plugman and cordova-cli >>> >>>under >>> >>> the >>> >>> >> >> > >> > > > 'plugman-registry' >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > Everything should be well documented under the >>> >>>project's >>> >>> >> README >>> >>> >> >> > but >>> >>> >> >> > >> I >>> >>> >> >> > >> > > > should probably update the wiki and write a blog post >>> >>>as >>> >>> >> well. >>> >>> >> >> > >> > >>> >>> >> >> > >> I don't see the README updated with any of the new features >>> >>> >> (looking >>> >>> >> >> > here: >>> >>> >> >> > >> >>> >>> >> >> > >> >>> >>> >> >> > >>> >>> >> >> >>> >>> >> >>> >>> >>> >>> >>> https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=blob_pla >>> >>>in;f=README.md;hb=plugman-registry >>> >>> >> >> > >> ) >>> >>> >> >> > >> >>> >>> >> >> > >> >>> >>> >> >> > >> >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > Now that 3.0 is released, I would like to merge this >>> >>> feature >>> >>> >> >> back >>> >>> >> >> > >> into >>> >>> >> >> > >> > > > master on both projects by the end of this week if >>> >>> possible. >>> >>> >> It >>> >>> >> >> > >> would >>> >>> >> >> > >> > be >>> >>> >> >> > >> > > > great if folks try it out and give me some feedback. >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > The registry is based on NPM and because of that, all >>> >>>of >>> >>> your >>> >>> >> >> > >> plugins >>> >>> >> >> > >> > > need >>> >>> >> >> > >> > > > to be renamed using NPM's conventions: all lowercase >>> >>>and >>> >>> no >>> >>> >> >> > spaces. >>> >>> >> >> > >> > I've >>> >>> >> >> > >> > > > already published some to plugins.cordova.io. >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > plugman allows to install, adduser, publish, unpublish >>> >>> and >>> >>> >> >> search. >>> >>> >> >> > >> > > > cordova-cli only allows installation and search. I >>> >>>think >>> >>> that >>> >>> >> >> > plugin >>> >>> >> >> > >> > > > authoring should be done with plugman as I am not sure >>> >>> what >>> >>> >> the >>> >>> >> >> > flow >>> >>> >> >> > >> > > would >>> >>> >> >> > >> > > > look like with cordova-cli. This can change. >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > The only difference between npm and plugman is the >>> >>> >> >> > (un)installation >>> >>> >> >> > >> > part. >>> >>> >> >> > >> > > > Everything else is pretty much the same. Plugin >>> >>>authors >>> >>> are >>> >>> >> not >>> >>> >> >> > >> > required >>> >>> >> >> > >> > > to >>> >>> >> >> > >> > > > write a package.json as this is automatically >>> >>>generated >>> >>> by >>> >>> >> the >>> >>> >> >> > tool >>> >>> >> >> > >> > from >>> >>> >> >> > >> > > > the plugin.xml. I've added a few tags to the >>> >>> specification to >>> >>> >> >> > >> support >>> >>> >> >> > >> > > this >>> >>> >> >> > >> > > > new use case. >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > Let me know if you have any questions or requests. >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > > Anis >>> >>> >> >> > >> > > > >>> >>> >> >> > >> > > >>> >>> >> >> > >> > >>> >>> >> >> > >> >>> >>> >> >> > > >>> >>> >> >> > > >>> >>> >> >> > >>> >>> >> >> >>> >>> >> >>> >>> >>> >> >>> >> >>> >>>
