I've updated the tests, and removed a lot of them (there's another thread about that now). I had to fix an unrelated issue to get them to work at all for me under Xcode5.
There are only four failing whitelist tests now -- it looks like we used to support IP wildcards, but don't any longer. I've brought that up in the other thread as well. Ian On Fri, Aug 30, 2013 at 9:46 AM, Ian Clelland <iclell...@chromium.org>wrote: > I haven't checked yet, but Andrew's guess is likely correct. I got those > unit tests working *before* I started the whitelist work, but never went > back to validate them afterwards. > > I'll see what I can do to clean them up. I think I would like to keep some > of those tests in place, as the code under test *is* all native code. > > > On Fri, Aug 30, 2013 at 9:39 AM, Andrew Grieve <agri...@chromium.org>wrote: > >> My guess is that Ian broke these tests when he changed the whitelist to >> behave the same way as Android's. He added whitelist unit tests to >> mobile-spec, so likely these can just be deleted? Will let him confirm >> when >> he gets in. >> >> >> On Fri, Aug 30, 2013 at 9:16 AM, David Kemp <drk...@google.com> wrote: >> >> > Confirmed. I get 715 fails >> > >> > >> > On Fri, Aug 30, 2013 at 4:45 AM, Shazron <shaz...@gmail.com> wrote: >> > >> > > Can someone verify my results? I noticed there were changes in the >> code >> > for >> > > CDVWhitelist.m, and I was trying to fix static analyzer errors and >> re-ran >> > > the tests before and after I made the changes. >> > > >> > >> > >
